Am 03.09.2011 12:40 schrieb Stefan Tauner:
On Fri, 02 Sep 2011 20:22:08 +0200 Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
the force_I_want_a_brick will override the other one (which is then neither used nor checked). i think that is ok... this is already way too sophisticated imho. :) but thanks for pointing it out, i have not thought about it yet. do you think this is a problem?
Yes. There are actually two issues:
i was specifically talking about the dmi code only. you are right about the programmer stuff, but that's another topic/patch (and i totally overlooked it, because i thought this is handled correctly :).
I never thought of that bug until Idwer mentioned it.
what do you think about this patch/idea?
I really like the ability to tell flashrom "this is not a laptop", full ACK from me for the idea. We just need to make sure the implementation will work as intended.
Regards, Carl-Daniel