Re: [flashrom] [PATCH] MSI MS-6787 board enable

[Michael Karcher]

Am Montag, den 16.08.2010, 14:53 +0400 schrieb Jon Shadow:
> Here's a patch that should make swiftgeek's board work.
>
> Signed-off-by: Sergey A Lichack

Thanks for your patch I helped you write on IRC. It has a critical
problem. Please *remove* all the subsystem IDs from your patch (i.e. the
3rd, 4th, 7th, 8th number), because with the subsystem IDs, the
match-via-PCI-IDs could trigger the board enable on a different board
that happens to have the same subsystem IDs (quite likely existing).

If the subsystem IDs are zero, board-matching via device is disabled.
I'm sorry I gave you the wrong advice.

Please also note that swiftgeek needs to add "-m msi:ms6787" for the
fixed version of that patch, while his/her board is autodetected with
the current patch.

Regards,
  Michael Karcher