Re: [flashrom] [commit] r1369 - trunk

[Stefan Tauner]

On Thu, 21 Jul 2011 20:47:36 +0200
Uwe Hermann  wrote:
> On Wed, Jul 13, 2011 at 12:01:44AM +0200, repository service wrote:
> > Author: stefanct
> > Date: Wed Jul 13 00:01:44 2011
> > New Revision: 1369
> > URL: http://flashrom.org/trac/flashrom/changeset/1369
> >
> > Log:
> > update motherboard URLs in print.c
> >
> > Signed-off-by: Benjamin Bellec 
> > with small changes:
> > Signed-off-by: Stefan Tauner 
> > Acked-by: Stefan Tauner
> >
> > Modified:
> >    trunk/print.c
> > Modified: trunk/print.c
> >
> > --- trunk/print.c	Sat Jul  9 21:46:53 2011	(r1368)
> > +++ trunk/print.c	Wed Jul 13 00:01:44 2011	(r1369)
> > @@ -376,15 +376,15 @@
> > @@ -525,9 +525,9 @@
> >    B("GIGABYTE",	"GA-6IEM",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=1379", NULL),
> >    B("GIGABYTE",	"GA-6VXE7+",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=2410", NULL),
> >    B("GIGABYTE",	"GA-6ZMA",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=1541", NULL),
> > B("GIGABYTE",	"GA-MA785GMT-UD2H",	1, "http://www.gigabyte.de/Products/Motherboard/Products_Overview.aspx?ProductID...", NULL),
> > B("GIGABYTE",	"GA-770TA-UD3",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=3272#ov", NULL),
> > B("GIGABYTE",	"GA-7DXR",		1, "http://www.gigabyte.de/Products/Motherboard/Products_Spec.aspx?ProductID=130...", NULL),
> > B("GIGABYTE",	"GA-MA785GMT-UD2H (rev. 1.0)", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=3156", NULL),
>
> Not sure about the "(rev. 1.0)". The original board report did indeed
> say 1.0, but we usually don't record that info in the boardname.
> Long-term we might introduce a field for that, but for now I'd rather omit
> version numbers (max. a comment), the 2.0 board will probably be also
> autodetected by the same board-enable (due to same PCI IDs) in most cases.
> The user will then see "1.0" whereas his board is "2.0" which will lead
> to confusion.

i think you are confusing this with the board enable printouts?
this is only for -L and wiki output... so i dont really see a problem.
also we have indicated exact revisions in the past whenever possible,
so this is nothing new.
> > B("MSI",	"MS-7061 (KM4M-V/KM4AM-V)", 1, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=594", NULL),
> > B("MSI",	"MS-7061 (KM3M-V/KM4M-V/KM4AM-V)", 1, "http://www.msi.com/service/search/?kw=7061&type=product", NULL),
>
> This doesn't look correct. The newly added "KM3M-V" is a KM266 Pro chipset,
> very likely with different PCI IDs than the KM400/KM400A which are used
> for the other two boards. Hence the board-enable will not be called.
> Why on earth they have the same MSI ID is beyond me.

they are very different yes, but as above... this is not a problem here.
no pci ids involved.
> > B("MSI",	"MS-7260 (K9N Neo)",	0, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=255", "Interestingly flashrom does not work when the vendor BIOS is booted, but it ''does'' work flawlessly when the machine is booted with coreboot. Owned by Uwe Hermann ."),
> > B("MSI",	"MS-7260 (K9N Neo PCB 1.0)", 0, "http://www.msi.com/product/mb/K9N-Neo--PCB-1-0-.html", "Interestingly flashrom does not work when the vendor BIOS is booted, but it ''does'' work flawlessly when the machine is booted with coreboot. Owned by Uwe Hermann ."),
>
> Same here wrt PCB revision.

... ;)