Re: [flashrom] [PATCH] Switch all chips to partial write

[Sean Nelson]

On 10/11/10 3:58 PM, Carl-Daniel Hailfinger wrote:
> On 11.10.2010 15:14, Maciej Pijanka wrote:
> > On Mon, 11 Oct 2010, Carl-Daniel Hailfinger wrote:
> > > Switch all flash chips to partial write.
> > > The inner write functions which handle partial write are renamed to the
> > > original name of their wrappers. The write wrappers are removed.
> > >
> > > This patch depends on
> > > Re: [flashrom] [PATCH] Refactor remaining write wrappers
> > > Tests are appreciated.
> > >
> > > Signed-off-by: Carl-Daniel Hailfinger
> >
> > This patch causes compile time problems in spi code, some functions were renamed
> > but *write_1_new() calls in few places remain (spi.c, it87spi.c)
>
> Thanks for the report. Those are now fixed.
> > After manual fixing of those test were performed using nic3com and at29c512.
> > logs in attachment, everything went ok and image read back is correct.
>
> Updated version with fixed compilation and some "interesting" (i.e. hard
> to know if they work) SPI changes. Write tests of SPI chips are
> appreciated, especially on boards which use the ITE IT87* Super I/O as
> flash controller.
>
> Switch all flash chips to partial write.
> The inner write functions which handle partial write are renamed to the
> original name of their wrappers. The write wrappers are removed.
>
> This patch depends on
> Re: [flashrom] [PATCH] Refactor remaining write wrappers
> Tests are appreciated.
>
> Please review this patch with lots of scrutiny. I don't really feel
> comfortable with the IT87* SPI changes nor with the AAI SPI changes,
> but they were needed to get the code to work, at least in theory.
>
> Signed-off-by: Carl-Daniel Hailfinger

Tested on M2N32-SLI, nVidia MCP55 with Winbond W39V080A
Acked-by: Sean Nelson