On 06.07.2010 11:52, Carl-Daniel Hailfinger wrote:
On 05.07.2010 22:32, Michael Karcher wrote:
Please change the pcidev stuff to use common code in pcidev_init and recheck the ordering in the buspirate file. With these changes:
Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Done, thanks for the review.
New version, addresses all comments except the it87spi stuff which will be handled in an updated it8705 support patch.
Various places in the flashrom source feature custom parameter extraction from programmer_param. This led to wildly differing syntax for programmer parameters, and it also voids pretty much every assumption you could make about programmer_param. The latter is a problem for libflashrom.
Use extract_param everywhere, clean up related code and make it more foolproof. Add two instances of exit(1) where we have no option to return an error. Remove six instances of exit(1) where returning an error was possible.
WARNING: This changes programmer parameter syntax for a few programmers!
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
I reused your ack and committed in r1070.
Regards, Carl-Daniel