Re: [flashrom] [PATCH] Add atapromise programmer

[Carl-Daniel Hailfinger]

Hi Joseph,

thanks!
Acked-by: Carl-Daniel Hailfinger 
and committed in r1916 with the following commit message:

Add atapromise programmer

Supported controllers are Promise PDC20262 (FastTrak66/Ultra66),
PDC20265 (FastTrak100 Lite/Ultra100), PDC20267 (FastTrak100/Ultra100).
At least the Ultra100 only has address lines A0-A14 wired up, limiting
addressable chip size to 32 kB. The flash chips mounted on those
controllers usually is 128 kB, i.e. parts of the flash chip are
inaccessible. As a workaround, the driver implicitly truncates the
size of all flash chips to 32 kB. Works well for the factory installed
flash.
Do NOT use as a generic programmer for chips >32 kB.

Signed-off-by: Joseph C. Lehner 
Acked-by: Carl-Daniel Hailfinger 
Acked-by: Urja Rannikko

Regards,
Carl-Daniel

On 16.01.2016 23:41, Joseph C. Lehner wrote:
> Hi Carl-Daniel,
>
> looks fine to me, thank you for your efforts!
>
> Regards,
> Joseph
>
> Signed-off-by: Joseph C. Lehner
>
> On 2016-01-16 23:35, Carl-Daniel Hailfinger wrote:
> > > Hi Joseph,
> > >
> > > thank you very much. I have added the requirements section to the man
> > > page and changed some whitespace and a comment in atapromise.c.
> > >
> > > Patch follows at the end of this mail. If you don't have any objections,
> > > may I ask you to sign off on that latest iteration, then I'll commit.
> > > Thanks again for submitting the patch and for addressing all our concerns.
> > >
> > > Regards,
> > > Carl-Daniel
> > >
> > > Index: flashrom-atapromise/Makefile