Re: [flashrom] [PATCH] Add Nvidia nForce MCP6x/MCP7x series SPI flashing support

3 Jul 2010

<> sudo flashrom -V
flashrom v0.9.2-r1069 on Linux 2.6.35-rc3 (x86_64), built with libpci 
3.0.0, GCC 4.4.3, little endian
flashrom is free software, get the source code at http://www.flashrom.org
Calibrating delay loop... OS timer resolution is 1 usecs, 1299M loops 
per second, 10 myus = 10 us, 100 myus = 100 us, 1000 myus = 999 us, 
10000 myus = 10007 us, 4 myus = 5 us, OK.
Initializing internal programmer
No coreboot table found.
DMI string system-manufacturer: "System manufacturer"
DMI string system-product-name: "System Product Name"
DMI string system-version: "System Version"
DMI string baseboard-manufacturer: "ASUSTeK Computer INC."
DMI string baseboard-product-name: "M4N78 PRO"
DMI string baseboard-version: "Rev 1.xx"
DMI string chassis-type: "Desktop"
Found ITE Super I/O, id 8720
Found chipset "NVIDIA MCP78S", enabling flash write... chipset PCI ID is 
10de:075c, This chipset is not really supported yet. Guesswork...
ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0
Guessed flash bus type is SPI
Found SMBus device 10de:0752 at 00:01:1
SPI BAR is at 0xfbd80000, after clearing low bits BAR is at 0xfbd80000
Mapping Nvidia MCP6x SPI at 0xfbd80000, unaligned size 0x544.
SPI control is 0xc01a, enable=0, idle=0
Please send the output of "flashrom -V" to flashrom@flashrom.org to help 
us finish support for your chipset. Thanks.
SPI on this chipset is WIP. DO NOT USE!
OK.
This chipset supports the following protocols: SPI.
No IT87* serial flash segment enabled.
Probing for AMD Am29F010A/B, 128 KB: skipped.
Probing for AMD Am29F002(N)BB, 256 KB: skipped.
Probing for AMD Am29F002(N)BT, 256 KB: skipped.
Probing for AMD Am29F016D, 2048 KB: skipped.
Probing for AMD Am29F040B, 512 KB: skipped.
Probing for AMD Am29F080B, 1024 KB: skipped.
Probing for AMD Am29LV040B, 512 KB: skipped.
Probing for AMD Am29LV081B, 1024 KB: skipped.
Probing for ASD AE49F2008, 256 KB: skipped.
Probing for Atmel AT25DF021, 256 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25DF041A, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25DF081, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25DF161, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25DF321, 4096 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25DF321A, 4096 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25DF641, 8192 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25F512B, 64 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25FS010, 128 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT25FS040, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT26DF041, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT26DF081A, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT26DF161, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT26DF161A, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT26F004, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT29C512, 64 KB: skipped.
Probing for Atmel AT29C010A, 128 KB: skipped.
Probing for Atmel AT29C020, 256 KB: skipped.
Probing for Atmel AT29C040A, 512 KB: skipped.
Probing for Atmel AT45CS1282, 16896 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Atmel AT45DB011D, 128 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB021D, 256 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB041D, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB081D, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB161D, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB321C, 4224 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB321D, 4096 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT45DB642D, 8192 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Atmel AT49BV512, 64 KB: skipped.
Probing for Atmel AT49F020, 256 KB: skipped.
Probing for Atmel AT49F002(N), 256 KB: skipped.
Probing for Atmel AT49F002(N)T, 256 KB: skipped.
Probing for AMIC A25L40PT, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for AMIC A25L40PU, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for AMIC A29002B, 256 KB: skipped.
Probing for AMIC A29002T, 256 KB: skipped.
Probing for AMIC A29040B, 512 KB: skipped.
Probing for AMIC A49LF040A, 512 KB: skipped.
Probing for EMST F49B002UA, 256 KB: skipped.
Probing for EMST F25L008A, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Eon EN25B05, 64 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for Eon EN25B05T, 64 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B10, 128 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B10T, 128 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B20, 256 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B20T, 256 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B40, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B40T, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B80, 1024 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B80T, 1024 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B16, 2048 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B16T, 2048 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B32, 4096 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B32T, 4096 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B64, 8192 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25B64T, 8192 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25D16, 2048 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25F05, 64 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for Eon EN25F10, 128 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25F20, 256 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25F40, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25F80, 1024 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25F16, 2048 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN25F32, 4096 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for Eon EN29F010, 128 KB: skipped.
Probing for EON EN29F002(A)(N)B, 256 KB: skipped.
Probing for EON EN29F002(A)(N)T, 256 KB: skipped.
Probing for Fujitsu MBM29F004BC, 512 KB: skipped.
Probing for Fujitsu MBM29F004TC, 512 KB: skipped.
Probing for Fujitsu MBM29F400BC, 512 KB: skipped.
Probing for Fujitsu MBM29F400TC, 512 KB: skipped.
Probing for Hyundai HY29F002T, 256 KB: skipped.
Probing for Hyundai HY29F002B, 256 KB: skipped.
Probing for Intel 28F001BX-B, 128 KB: skipped.
Probing for Intel 28F001BX-T, 128 KB: skipped.
Probing for Intel 28F004S5, 512 KB: skipped.
Probing for Intel 28F004BV/BE-B, 512 KB: skipped.
Probing for Intel 28F004BV/BE-T, 512 KB: skipped.
Probing for Intel 28F400BV/CV/CE-B, 512 KB: skipped.
Probing for Intel 28F400BV/CV/CE-T, 512 KB: skipped.
Probing for Intel 82802AB, 512 KB: skipped.
Probing for Intel 82802AC, 1024 KB: skipped.
Probing for Macronix MX25L512, 64 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Macronix MX25L1005, 128 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L2005, 256 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L4005, 512 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L8005, 1024 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L1605, 2048 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L1635D, 2048 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L3205, 4096 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L3235D, 4096 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L6405, 8192 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX25L12805, 16384 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix MX29F001B, 128 KB: skipped.
Probing for Macronix MX29F001T, 128 KB: skipped.
Probing for Macronix MX29F002B, 256 KB: skipped.
Probing for Macronix MX29F002T, 256 KB: skipped.
Probing for Macronix MX29LV040, 512 KB: skipped.
Probing for Numonyx M25PE10, 128 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Numonyx M25PE20, 256 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Numonyx M25PE40, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Numonyx M25PE80, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Numonyx M25PE16, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for PMC Pm25LV010, 128 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for PMC Pm25LV016B, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for PMC Pm25LV020, 256 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for PMC Pm25LV040, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for PMC Pm25LV080B, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for PMC Pm25LV512, 64 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for PMC Pm29F002T, 256 KB: skipped.
Probing for PMC Pm29F002B, 256 KB: skipped.
Probing for PMC Pm39LV010, 128 KB: skipped.
Probing for PMC Pm39LV020, 256 KB: skipped.
Probing for PMC Pm39LV040, 512 KB: skipped.
Probing for PMC Pm49FL002, 256 KB: skipped.
Probing for PMC Pm49FL004, 512 KB: skipped.
Probing for Sanyo LF25FW203A, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Sharp LHF00L04, 1024 KB: skipped.
Probing for Spansion S25FL008A, 1024 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Spansion S25FL016A, 2048 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for SST SST25VF016B, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for SST SST25VF032B, 4096 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for SST SST25VF040.REMS, 512 KB: probe_spi_rems: id1 0xef, id2 0x13
Probing for SST SST25VF040B, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for SST SST25LF040A.RES, 512 KB: probe_spi_res2: id1 0x13, id2 0x13
Probing for SST SST25VF040B.REMS, 512 KB: probe_spi_rems: id1 0xef, id2 0x13
Probing for SST SST25VF080B, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for SST SST28SF040A, 512 KB: skipped.
Probing for SST SST29EE010, 128 KB: skipped.
Probing for SST SST29LE010, 128 KB: skipped.
Probing for SST SST29EE020A, 256 KB: skipped.
Probing for SST SST29LE020, 256 KB: skipped.
Probing for SST SST39SF512, 64 KB: skipped.
Probing for SST SST39SF010A, 128 KB: skipped.
Probing for SST SST39SF020A, 256 KB: skipped.
Probing for SST SST39SF040, 512 KB: skipped.
Probing for SST SST39VF512, 64 KB: skipped.
Probing for SST SST39VF010, 128 KB: skipped.
Probing for SST SST39VF020, 256 KB: skipped.
Probing for SST SST39VF040, 512 KB: skipped.
Probing for SST SST39VF080, 1024 KB: skipped.
Probing for SST SST49LF002A/B, 256 KB: skipped.
Probing for SST SST49LF003A/B, 384 KB: skipped.
Probing for SST SST49LF004A/B, 512 KB: skipped.
Probing for SST SST49LF004C, 512 KB: skipped.
Probing for SST SST49LF008A, 1024 KB: skipped.
Probing for SST SST49LF008C, 1024 KB: skipped.
Probing for SST SST49LF016C, 2048 KB: skipped.
Probing for SST SST49LF020, 256 KB: skipped.
Probing for SST SST49LF020A, 256 KB: skipped.
Probing for SST SST49LF040, 512 KB: skipped.
Probing for SST SST49LF040B, 512 KB: skipped.
Probing for SST SST49LF080A, 1024 KB: skipped.
Probing for SST SST49LF160C, 2048 KB: skipped.
Probing for ST M25P05-A, 64 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P05.RES, 64 KB: Ignoring RES in favour of RDID.
Probing for ST M25P10-A, 128 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for ST M25P10.RES, 128 KB: Ignoring RES in favour of RDID.
Probing for ST M25P20, 256 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P40, 512 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P40-old, 512 KB: Ignoring RES in favour of RDID.
Probing for ST M25P80, 1024 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P16, 2048 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P32, 4096 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P64, 8192 KB: probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for ST M25P128, 16384 KB: probe_spi_rdid_generic: id1 0xef, id2 
0x3014
Probing for ST M29F002B, 256 KB: skipped.
Probing for ST M29F002T/NT, 256 KB: skipped.
Probing for ST M29F040B, 512 KB: skipped.
Probing for ST M29F400BT, 512 KB: skipped.
Probing for ST M29W010B, 128 KB: skipped.
Probing for ST M29W040B, 512 KB: skipped.
Probing for ST M29W512B, 64 KB: skipped.
Probing for ST M50FLW040A, 512 KB: skipped.
Probing for ST M50FLW040B, 512 KB: skipped.
Probing for ST M50FLW080A, 1024 KB: skipped.
Probing for ST M50FLW080B, 1024 KB: skipped.
Probing for ST M50FW002, 256 KB: skipped.
Probing for ST M50FW016, 2048 KB: skipped.
Probing for ST M50FW040, 512 KB: skipped.
Probing for ST M50FW080, 1024 KB: skipped.
Probing for ST M50LPW116, 2048 KB: skipped.
Probing for SyncMOS S29C31004T, 512 KB: skipped.
Probing for SyncMOS S29C51001T, 128 KB: skipped.
Probing for SyncMOS S29C51002T, 256 KB: skipped.
Probing for SyncMOS S29C51004T, 512 KB: skipped.
Probing for TI TMS29F002RB, 256 KB: skipped.
Probing for TI TMS29F002RT, 256 KB: skipped.
Probing for Winbond W25Q80, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25Q16, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25Q32, 4096 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25Q64, 8192 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25x10, 128 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25x20, 256 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25x40, 512 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25x80, 1024 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Chip status register is 00
Found chip "Winbond W25x80" (1024 KB, SPI) at physical address 0xfff00000.
Probing for Winbond W25x16, 2048 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25x32, 4096 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W25x64, 8192 KB: probe_spi_rdid_generic: id1 0xef, 
id2 0x3014
Probing for Winbond W29C011, 128 KB: skipped.
Probing for Winbond W29C020C, 256 KB: skipped.
Probing for Winbond W29C040P, 512 KB: skipped.
Probing for Winbond W29EE011, 128 KB: skipped.
Probing for Winbond W39V040A, 512 KB: skipped.
Probing for Winbond W39V040B, 512 KB: skipped.
Probing for Winbond W39V040C, 512 KB: skipped.
Probing for Winbond W39V040FA, 512 KB: skipped.
Probing for Winbond W39V080A, 1024 KB: skipped.
Probing for Winbond W49F002U, 256 KB: skipped.
Probing for Winbond W49V002A, 256 KB: skipped.
Probing for Winbond W49V002FA, 256 KB: skipped.
Probing for Winbond W39V080FA, 1024 KB: skipped.
Probing for Winbond W39V080FA (dual mode), 512 KB: skipped.
Probing for Atmel unknown Atmel SPI chip, 0 KB: probe_spi_rdid_generic: 
id1 0xef, id2 0x3014
Probing for EON unknown EON SPI chip, 0 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Macronix unknown Macronix SPI chip, 0 KB: 
probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for PMC unknown PMC SPI chip, 0 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for SST unknown SST SPI chip, 0 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for ST unknown ST SPI chip, 0 KB: probe_spi_rdid_generic: id1 
0xef, id2 0x3014
Probing for Sanyo unknown Sanyo SPI chip, 0 KB: probe_spi_rdid_generic: 
id1 0xef, id2 0x3014
Probing for Generic unknown SPI chip (RDID), 0 KB: 
probe_spi_rdid_generic: id1 0xef, id2 0x3014
Probing for Generic unknown SPI chip (REMS), 0 KB: probe_spi_rems: id1 
0xef, id2 0x13
===
This flash part has status UNTESTED for operations: ERASE
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above 
operations
work correctly for you with this flash part. Please include the flashrom
output with the additional -V option for all operations you tested (-V, -Vr,
-Vw, -VE), and mention which mainboard or programmer you tested.
Thanks for your help!
===
No operations were specified.
On 07/03/2010 09:29 AM, Carl-Daniel Hailfinger wrote:
...
Hi,
you have sent a report for a mainboard with Nvidia nForce chipset, and
we now have a patch to support your chipset and would appreciate if you
could test (unless you can't recover in case something goes wrong).
The following chipsets would be nice to get reports for:
MCP61: Andrew Cleveland, Free Wind, Andre Robatino, Антон Кочков,
Benjamin Henrion, Chris Yagami, Jim Lunsford
MCP65: Kjell Braden, Mark Morschhäuser, Melchior FRANZ, Wolfgang Schnitker
MCP67: Alessandro Polverini, NotLim
MCP73: Noe, Maik Masling
MCP78S: Ivo Anjo, Julian Hughes, Dietmar Gaffron, Kimmo Vuorinen, Urja
Rannikko, ataya65, Vikram Noel Ambrose, Marcel Partap, antioxid, Rainer
Stumbaum, Brad Rogers
MCP79: Alex Neblett, J.P. Krauss, Ivo Anjo, Halim Sahin, Joakim
Gissberg, Benjamin Eugler
This code has been tested for probe/read for the following chipsets:
MCP65: Johannes Sjölund
MCP79: Andrew Morgan
Testing instructions
This patch may fry your flash chip, explode mysteriously and abduct your
dog, but so far it looks good.
Do NOT try to read/write/erase with this code until we know that it
behaves correctly.
Please apply this patch to the latest flashrom svn (subversion) tree,
recompile and then run
flashrom -V
This command should be reasonably safe (it only tries to identify your
flash chip), but if you don't have a way to recover from a bad flash,
please don't try it.
Then please mail the output from the command above to the flashrom
mailing list (preferably as reply to this mail). Doing this on your
boards with newer (last 5 years) Nvidia nForce chipsets would be highly
appreciated.
You can also find this patch near the top at
http://patchwork.coreboot.org/project/flashrom/list/ in case your mailer
corrupts the patch. It applies against latest clean svn tree.
Patch description
Add Nvidia nForce MCP61/MCP65/MCP67/MCP78S/MCP73/MCP79 SPI flashing support.
Fix a few problems in the previously unused SPI bitbanging core.
Huge thanks go to Michael Karcher for reverse engineering the interface
and to Johannes Sjölund for testing multiple iterations of my patch on
his hardware until it worked.
Signed-off-by: Carl-Daniel Hailfingerc-d.hailfinger.devel.2006@gmx.net
Index: flashrom-bitbang_spi_nvidia_mcp/flash.h

--- flashrom-bitbang_spi_nvidia_mcp/flash.h	(Revision 1069)
+++ flashrom-bitbang_spi_nvidia_mcp/flash.h	(Arbeitskopie)
@@ -128,13 +128,16 @@
  void programmer_delay(int usecs);
enum bitbang_spi_master {
+#if CONFIG_INTERNAL == 1
+#if defined(__i386__) || defined(__x86_64__)

BITBANG_SPI_MASTER_MCP,

+#endif
+#endif
   BITBANG_SPI_INVALID /* This must always be the last entry. */
  };
extern const int bitbang_spi_master_count;
-extern enum bitbang_spi_master bitbang_spi_master;

struct bitbang_spi_master_entry {
 void (*set_cs) (int val);
 void (*set_sck) (int val);

@@ -530,10 +533,22 @@
  int ft2232_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len);
  int ft2232_spi_write_256(struct flashchip *flash, uint8_t *buf);
+/* mcp6x_spi.c */
+#if CONFIG_INTERNAL == 1
+#if defined(__i386__) || defined(__x86_64__)
+extern void *mcp6x_spibar;
+int mcp6x_spi_init(void);
+void mcp6x_bitbang_set_cs(int val);
+void mcp6x_bitbang_set_sck(int val);
+void mcp6x_bitbang_set_mosi(int val);
+int mcp6x_bitbang_get_miso(void);
+#endif
+#endif

/* bitbang_spi.c */
extern int bitbang_spi_half_period;
extern const struct bitbang_spi_master_entry bitbang_spi_master_table[];

-int bitbang_spi_init(void);
+int bitbang_spi_init(enum bitbang_spi_master master);
  int bitbang_spi_send_command(unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr);
  int bitbang_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len);
  int bitbang_spi_write_256(struct flashchip *flash, uint8_t *buf);
@@ -637,6 +652,7 @@
   SPI_CONTROLLER_SB600,
   SPI_CONTROLLER_VIA,
   SPI_CONTROLLER_WBSIO,

SPI_CONTROLLER_MCP6X_BITBANG,
#endif
#endif
#if CONFIG_FT2232_SPI == 1

Index: flashrom-bitbang_spi_nvidia_mcp/hwaccess.h
--- flashrom-bitbang_spi_nvidia_mcp/hwaccess.h	(Revision 1069)
+++ flashrom-bitbang_spi_nvidia_mcp/hwaccess.h	(Arbeitskopie)
@@ -176,6 +176,10 @@
  #define __DARWIN__
  #endif
+/* Clarification about OUTB/OUTW/OUTL argument order:


OUT[BWL](val, port)


*/
#if defined(__FreeBSD__) || defined(__DragonFly__)
  #include<machine/cpufunc.h>
  #define off64_t off_t

Index: flashrom-bitbang_spi_nvidia_mcp/bitbang_spi.c
--- flashrom-bitbang_spi_nvidia_mcp/bitbang_spi.c	(Revision 1069)
+++ flashrom-bitbang_spi_nvidia_mcp/bitbang_spi.c	(Arbeitskopie)
@@ -26,17 +26,29 @@
  #include "chipdrivers.h"
  #include "spi.h"
-/* Length of half a clock period in usecs */
-int bitbang_spi_half_period = 0;
+/* Length of half a clock period in usecs. Default to 1 (500 kHz). */
+int bitbang_spi_half_period = 1;
enum bitbang_spi_master bitbang_spi_master = BITBANG_SPI_INVALID;
const struct bitbang_spi_master_entry bitbang_spi_master_table[] = {
+#if CONFIG_INTERNAL == 1
+#if defined(__i386__) || defined(__x86_64__)

{
.set_cs = mcp6x_bitbang_set_cs,


.set_sck = mcp6x_bitbang_set_sck,


.set_mosi = mcp6x_bitbang_set_mosi,


.get_miso = mcp6x_bitbang_get_miso,


},

+#endif
+#endif

{}, /* This entry corresponds to BITBANG_SPI_INVALID. */
};
const int bitbang_spi_master_count = ARRAY_SIZE(bitbang_spi_master_table);


+/* Note that CS# is active low, so val=0 means the chip is active. */
  void bitbang_spi_set_cs(int val)
  {
   bitbang_spi_master_table[bitbang_spi_master].set_cs(val);
@@ -57,10 +69,18 @@
   return bitbang_spi_master_table[bitbang_spi_master].get_miso();
  }
-int bitbang_spi_init(void)
+int bitbang_spi_init(enum bitbang_spi_master master)
  {

bitbang_spi_master = master;

if (bitbang_spi_master == BITBANG_SPI_INVALID) {
msg_perr("Invalid bitbang SPI master. \n"


	 "Please report a bug at flashrom@flashrom.org\n");


return 1;


}
bitbang_spi_set_cs(1);
bitbang_spi_set_sck(0);
bitbang_spi_set_mosi(0);
buses_supported = CHIP_BUSTYPE_SPI;
return 0;
}

@@ -87,6 +107,7 @@
  {
   static unsigned char *bufout = NULL;
   static unsigned char *bufin = NULL;

unsigned char *tmp;
static int oldbufsize = 0;
int bufsize;
int i;

@@ -98,20 +119,34 @@
   bufsize = max(writecnt + readcnt, 260);
   /* Never shrink. realloc() calls are expensive. */
   if (bufsize>  oldbufsize) {

bufout = realloc(bufout, bufsize);


if (!bufout) {




tmp = realloc(bufout, bufsize);


if (!tmp) {
msg_perr("Out of memory!\n");


	if (bufout)


		free(bufout);


	bufout = NULL;
if (bufin)
	free(bufin);


	bufin = NULL;


	oldbufsize = 0;
exit(1);




}


bufin = realloc(bufout, bufsize);


if (!bufin) {




} else


	bufout = tmp;



tmp = realloc(bufin, bufsize);


if (!tmp) {
msg_perr("Out of memory!\n");


	if (bufin)


		free(bufin);


	bufin = NULL;
if (bufout)
	free(bufout);


	bufout = NULL;


	oldbufsize = 0;
exit(1);




}




} else


	bufin = tmp;


oldbufsize = bufsize;
 }

@@ -135,8 +170,13 @@
int bitbang_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len)
  {

/* Maximum read length is unlimited, use 64k bytes. */
return spi_read_chunked(flash, buf, start, len, 64 * 1024);


/* Maximum read length is unlimited in theory.

* The current implementation can handle reads of up to 65536 bytes.


* Please note that you need two buffers of 2n+4 bytes each for a read


* of n bytes, resulting in a total memory requirement of 4n+8 bytes.


* To conserve memory, read in chunks of 256 bytes.


*/


return spi_read_chunked(flash, buf, start, len, 256);
}
int bitbang_spi_write_256(struct flashchip *flash, uint8_t *buf)


Index: flashrom-bitbang_spi_nvidia_mcp/spi.c
--- flashrom-bitbang_spi_nvidia_mcp/spi.c	(Revision 1069)
+++ flashrom-bitbang_spi_nvidia_mcp/spi.c	(Arbeitskopie)
@@ -82,6 +82,13 @@
   	.read = wbsio_spi_read,
   	.write_256 = wbsio_spi_write_1,
   },


{ /* SPI_CONTROLLER_MCP6X_BITBANG */
.command = bitbang_spi_send_command,


.multicommand = default_spi_send_multicommand,


.read = bitbang_spi_read,


.write_256 = bitbang_spi_write_256,


},
#endif
#endif

Index: flashrom-bitbang_spi_nvidia_mcp/Makefile
--- flashrom-bitbang_spi_nvidia_mcp/Makefile	(Revision 1069)
+++ flashrom-bitbang_spi_nvidia_mcp/Makefile	(Arbeitskopie)
@@ -111,8 +111,12 @@
  # Always enable serprog for now. Needs to be disabled on Windows.
  CONFIG_SERPROG ?= yes
-# Bitbanging SPI infrastructure is not used yet.
+# Bitbanging SPI infrastructure, default off unless needed.
+ifeq ($(CONFIG_INTERNAL), yes)
+CONFIG_BITBANG_SPI = yes
+else
  CONFIG_BITBANG_SPI ?= no
+endif
# Always enable 3Com NICs for now.
  CONFIG_NIC3COM ?= yes
@@ -155,7 +159,7 @@
  FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1'
  PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o dmi.o internal.o
  # FIXME: The PROGRAMMER_OBJS below should only be included on x86.
-PROGRAMMER_OBJS += it87spi.o ichspi.o sb600spi.o wbsio_spi.o
+PROGRAMMER_OBJS += it87spi.o ichspi.o sb600spi.o wbsio_spi.o mcp6x_spi.o
  NEED_PCI := yes
  endif
Index: flashrom-bitbang_spi_nvidia_mcp/chipset_enable.c
--- flashrom-bitbang_spi_nvidia_mcp/chipset_enable.c	(Revision 1069)
+++ flashrom-bitbang_spi_nvidia_mcp/chipset_enable.c	(Arbeitskopie)
@@ -1124,10 +1124,8 @@
  {
   int ret = 0;
   uint8_t val;

uint16_t status;
char *busname;
uint32_t mcp_spibaraddr;
void *mcp_spibar;


uint32_t mcp6x_spibaraddr;
struct pci_dev *smbusdev;
msg_pinfo("This chipset is not really supported yet. Guesswork...\n");


@@ -1176,40 +1174,33 @@
   	smbusdev->bus, smbusdev->dev, smbusdev->func);
/* Locate the BAR where the SPI interface lives. */

mcp_spibaraddr = pci_read_long(smbusdev, 0x74);
msg_pdbg("SPI BAR is at 0x%08x, ", mcp_spibaraddr);


mcp6x_spibaraddr = pci_read_long(smbusdev, 0x74);
msg_pdbg("SPI BAR is at 0x%08x, ", mcp6x_spibaraddr);
/* We hope this has native alignment. We know the SPI interface (well,
a set of GPIOs that is connected to SPI flash) is at offset 0x530,
so we expect a size of at least 0x800. Clear the lower bits.
It is entirely possible that the BAR is 64k big and the low bits are
reserved for an entirely different purpose.

*/


mcp_spibaraddr&= ~0x7ff;
msg_pdbg("after clearing low bits BAR is at 0x%08x\n", mcp_spibaraddr);


mcp6x_spibaraddr&= ~0x7ff;

msg_pdbg("after clearing low bits BAR is at 0x%08x\n", mcp6x_spibaraddr);
/* Accessing a NULL pointer BAR is evil. Don't do it. */



if (mcp_spibaraddr&&  (buses_supported == CHIP_BUSTYPE_SPI)) {


if (mcp6x_spibaraddr&&  (buses_supported == CHIP_BUSTYPE_SPI)) {
/* Map the BAR. Bytewise/wordwise access at 0x530 and 0x540. */


mcp_spibar = physmap("MCP67 SPI", mcp_spibaraddr, 0x544);




mcp6x_spibar = physmap("Nvidia MCP6x SPI", mcp6x_spibaraddr, 0x544);




-/* Guessed. If this is correct, migrate to a separate MCP67 SPI driver. */
-#define MCP67_SPI_CS		(1<<  1)
-#define MCP67_SPI_SCK		(1<<  2)
-#define MCP67_SPI_MOSI		(1<<  3)
-#define MCP67_SPI_MISO		(1<<  4)
-#define MCP67_SPI_ENABLE	(1<<  0)
-#define MCP67_SPI_IDLE		(1<<  8)


status = mmio_readw(mcp_spibar + 0x530);


msg_pdbg("SPI control is 0x%04x, enable=%i, idle=%i\n",


	 status, status&  0x1, (status>>  8)&  0x1);




if (mcp6x_spi_init())


	ret = 1;



+#if 0
   	/* FIXME: Remove the physunmap once the SPI driver exists. */

physunmap(mcp_spibar, 0x544);


} else if (!mcp_spibaraddr&&  (buses_supported&  CHIP_BUSTYPE_SPI)) {


physunmap(mcp6x_spibar, 0x544);



+#endif

} else if (!mcp6x_spibaraddr&&  (buses_supported&  CHIP_BUSTYPE_SPI)) {
msg_pdbg("Strange. MCP SPI BAR is invalid.\n");
buses_supported&= ~CHIP_BUSTYPE_SPI;
ret = 1;


} else if (mcp_spibaraddr&&  !(buses_supported&  CHIP_BUSTYPE_SPI)) {


} else if (mcp6x_spibaraddr&&  !(buses_supported&  CHIP_BUSTYPE_SPI)) {
msg_pdbg("Strange. MCP SPI BAR is valid, but chipset apparently"
	 " doesn't have SPI enabled.\n");
} else {

@@ -1247,8 +1238,8 @@
   	result = enable_flash_mcp55(dev, name);
   	break;
   case CHIP_BUSTYPE_SPI:

msg_pinfo("SPI on this chipset is not supported yet.\n");


buses_supported = CHIP_BUSTYPE_NONE;




msg_perr("SPI on this chipset is WIP. DO NOT USE!\n");


programmer_may_write = 0;

break;
default:
msg_pinfo("Something went wrong with bus type detection.\n");

@@ -1273,8 +1264,8 @@
   	msg_pinfo("LPC on this chipset is not supported yet.\n");
   	break;
   case CHIP_BUSTYPE_SPI:

msg_pinfo("SPI on this chipset is not supported yet.\n");


buses_supported = CHIP_BUSTYPE_NONE;




msg_perr("SPI on this chipset is WIP. DO NOT USE!\n");


programmer_may_write = 0;

break;
default:
msg_pinfo("Something went wrong with bus type detection.\n");

Index: flashrom-bitbang_spi_nvidia_mcp/mcp6x_spi.c
--- flashrom-bitbang_spi_nvidia_mcp/mcp6x_spi.c	(Revision 0)
+++ flashrom-bitbang_spi_nvidia_mcp/mcp6x_spi.c	(Revision 0)
@@ -0,0 +1,132 @@
+/*


This file is part of the flashrom project.







Copyright (C) 2010 Carl-Daniel Hailfinger







This program is free software; you can redistribute it and/or modify



it under the terms of the GNU General Public License as published by



the Free Software Foundation; version 2 of the License.







This program is distributed in the hope that it will be useful,



but WITHOUT ANY WARRANTY; without even the implied warranty of



MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the



GNU General Public License for more details.







You should have received a copy of the GNU General Public License



along with this program; if not, write to the Free Software



Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA


*/


+/* Driver for the Nvidia MCP6x/MCP7x MCP6X_SPI controller.


Based on clean room reverse engineered docs from



http://www.flashrom.org/pipermail/flashrom/2009-December/001180.html



created by Michael Karcher.


*/


+#if defined(__i386__) || defined(__x86_64__)



+#include<stdint.h>
+#include<stdlib.h>
+#include<ctype.h>
+#include "flash.h"



+/* We have two sets of pins, out and in. The numbers for both sets are


independent and are bitshift values, not real pin numbers.


*/


+/* Guessed. */
+#define MCP6X_SPI_CS		1
+#define MCP6X_SPI_SCK		2
+#define MCP6X_SPI_MOSI		3
+#define MCP6X_SPI_MISO		4
+#define MCP6X_SPI_ENABLE	0
+#define MCP6X_SPI_IDLE		8



+void *mcp6x_spibar = NULL;



+void mcp6x_request_spibus(void)
+{

uint8_t byte;

byte = mmio_readb(mcp6x_spibar + 0x530);
byte |= 1<<  MCP6X_SPI_ENABLE;
mmio_writeb(byte, mcp6x_spibar + 0x530);

/* Wait until we are allowed to use the SPI bus. */
while (!(mmio_readw(mcp6x_spibar + 0x530)&  (1<<  MCP6X_SPI_IDLE))) ;

+}



+void mcp6x_release_spibus(void)
+{

uint8_t byte;

byte = mmio_readb(mcp6x_spibar + 0x530);
byte&= ~(1<<  MCP6X_SPI_ENABLE);
mmio_writeb(byte, mcp6x_spibar + 0x530);

+}



+void mcp6x_bitbang_set_cs(int val)
+{

uint8_t byte;

/* Requesting and releasing the SPI bus is handled in here to allow the
* chipset to use its own SPI engine for native reads.


*/


if (val == 0)
mcp6x_request_spibus();



byte = mmio_readb(mcp6x_spibar + 0x530);
byte&= ~(1<<  MCP6X_SPI_CS);
byte |= (val<<  MCP6X_SPI_CS);
mmio_writeb(byte, mcp6x_spibar + 0x530);

if (val == 1)
mcp6x_release_spibus();



+}



+void mcp6x_bitbang_set_sck(int val)
+{

uint8_t byte;

byte = mmio_readb(mcp6x_spibar + 0x530);
byte&= ~(1<<  MCP6X_SPI_SCK);
byte |= (val<<  MCP6X_SPI_SCK);
mmio_writeb(byte, mcp6x_spibar + 0x530);

+}



+void mcp6x_bitbang_set_mosi(int val)
+{

uint8_t byte;

byte = mmio_readb(mcp6x_spibar + 0x530);
byte&= ~(1<<  MCP6X_SPI_MOSI);
byte |= (val<<  MCP6X_SPI_MOSI);
mmio_writeb(byte, mcp6x_spibar + 0x530);

+}



+int mcp6x_bitbang_get_miso(void)
+{

uint8_t byte;

byte = mmio_readb(mcp6x_spibar + 0x530);
byte = (byte>>  MCP6X_SPI_MISO)&  0x1;
return byte;

+}



+int mcp6x_spi_init(void)
+{

uint16_t status;

status = mmio_readw(mcp6x_spibar + 0x530);
msg_pdbg("SPI control is 0x%04x, enable=%i, idle=%i\n",
 status, (status>>  MCP6X_SPI_ENABLE)&  0x1,


 (status>>  MCP6X_SPI_IDLE)&  0x1);



if (bitbang_spi_init(BITBANG_SPI_MASTER_MCP))
return 1;


spi_controller = SPI_CONTROLLER_MCP6X_BITBANG;

return 0;

+}



+#endif

    

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Re: [flashrom] [PATCH] Add Nvidia nForce MCP6x/MCP7x series SPI flashing support

Testing instructions

Patch description

Index: flashrom-bitbang_spi_nvidia_mcp/flash.h

Index: flashrom-bitbang_spi_nvidia_mcp/hwaccess.h

Index: flashrom-bitbang_spi_nvidia_mcp/bitbang_spi.c

Index: flashrom-bitbang_spi_nvidia_mcp/spi.c

Index: flashrom-bitbang_spi_nvidia_mcp/Makefile

Index: flashrom-bitbang_spi_nvidia_mcp/chipset_enable.c

Index: flashrom-bitbang_spi_nvidia_mcp/mcp6x_spi.c