Hi Misha,
On 15.07.2010 01:44, Michael Manulis wrote:
On Wed, Jul 14, 2010 at 4:03 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
I have added flashrom@flashrom.org to CC again to make sure others can follow us.
On 12.07.2010 20:06, Michael Manulis wrote:
I finally got around to checking your patch. Short story, flashrom could not find any flash chips. The log as follows. I had to make one change to get the code to compile on PPC, here's the diff:
Index: chipset_enable.c
--- chipset_enable.c (revision 1075) +++ chipset_enable.c (working copy) @@ -33,10 +33,10 @@ #include <unistd.h> #include "flash.h"
+#define NOT_DONE_YET 1
#if defined(__i386__) || defined(__x86_64__)
-#define NOT_DONE_YET 1
static int enable_flash_ali_m1533(struct pci_dev *dev, const char *name) { uint8_t tmp;
Thanks. I already had that change in my local tree, but forgot to push it.
Good. That's expected when using the default internal programmer. IIRC you wanted to flash the SATA controller on your CurtisWright Raptor. Could you try flashrom -p satasii -V
I ran the following commands to test the patch:
./flashrom -p satasii -V ./flashrom -p satasii -Vr sata.dump ls -lh sata.dump ./flashrom -p satasii -VE ./flashrom -p satasii -Vr zero.dump hexdump zero.dump ./flashrom -p satasii -Vw sata.dump ./flashrom -p satasii -Vv sata.dump
I attached the log as the file is 100K and I was reluctant to just paste it in the body.
The log is also available on pastebin.com at http://pastebin.com/kHkynj7s
Please let me know if you would like me to run other tests.
I tried to find people with deep PCI and architecture knowledge for reviews, but they are all extremely busy. However, since you tested this successfully, I think we can say this is safe.
Could you reply-to-all with the following line:
Acked-by: Your Name your@email
so I can go ahead and commit this change? Thanks!
Regards, Carl-Daniel