Re: [flashrom] [PATCH] Add support for ASUS M2V-MX board

[Luc Verhaegen]

On Sat, Dec 05, 2009 at 12:57:22AM +0100, Luc Verhaegen wrote:
> On Sat, Dec 05, 2009 at 12:41:37AM +0100, Carl-Daniel Hailfinger wrote:
> > Hi Luc,
> >
> > I almost committed this patch, then I found a line which you might
> > object to. We have a lspci for exactly this board from another user.
> >  Subject: [flashrom] Asus M2V-MX information
> >  From: Michael Spang
> >
> > On 30.11.2009 10:19, David Bartley wrote:
> > > {0x1106, 0x3337, 0x1043, 0x80ed,  0x1106, 0xB188,      0,      0, NULL,         NULL,          "ASUS",        "M2V-MX",             board_asus_m2v_mx},
> >
> > We might want to pick a pair of device IDs which has subsystems.
> >
> > Regards,
> > Carl-Daniel
>
> Strange, so the "m2v-mx" requires a board enable, while the "m2v-mx se" 
> (which i own) doesn't?
>
> First, i have some patches here to tighten up the match table, and i 
> intend to just go ahead and commit them after a bit of settling time.
>
> Secondly, after that, the board matching will become a lot more strict.
> If there is any subsystem id present, all subsystem ids will be used.
> If one of the four subsystem ids is not null, all nulls have to be 
> matched by the hardware too. So the second set of subsystem ids here 
> better be nulls for real :)
>
> Luc Verhaegen.

aha, MX is lpc, MX SE is spi, so vastly different boards.

Luc Verhaegen.