Re: [flashrom] [PATCH] Board enable for MSI MS-6561 (SiS 745)

[Uwe Hermann]

On Sat, Sep 11, 2010 at 06:18:52AM +0200, Mattias Mattsson wrote:
> This patch adds a board enable for MSI MS-6561 (745 Ultra). SiS 745
> chipset + Winbond W83697HF and Winbond W49F002U flash. Probe, read,
> erase and write all work.
>
> Matching on "NB/SB" (they are integrated). Also mark SiS 745 chipset
> as tested. W49F002U is already PREW.
>
> lspci/superiotool output and flashrom logs attached.
>
> Thanks,
>
> Signed-off-by: Mattias Mattsson

Thanks, r1158. I added the Super I/O name in the code comment, just in case.
> DMI string system-manufacturer: "MSI                             "
> DMI string system-product-name: "MS-6561                         "
> DMI string system-version: "1.0                             "
> DMI string baseboard-manufacturer: "MSI                             "
> DMI string baseboard-product-name: "MS-6561                         "

Hm, those extra spaces don't allow us to use "^MS-6561$" I guess, i.e.
we have to use "^MS-6561" which may or may not also match other boards?
Not sure what the regex syntax in flashrom supports or not, maybe we can
improve the match?

Also, can someone who knows more about subsystem IDs than me check if
there are useful ones to match here? I guess not, from what I can see,
but it would be good if someone else could cross-check.

Uwe.