On Sun, 2010-07-11 at 20:25 +0200, Michael Karcher wrote:
Your patch looks mostly fine. Please add a sign-off according to http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Also, please use tabs instead of spaces before the comment in flashchips.h.
Except for the tab issue, the patch is Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Got it, thanks. Corrected patch for AMIC A25L80P attached.
Signed-off-by: Daniel Lenski dlenski@gmail.com