Re: [flashrom] [PATCH] Add Spi interface support for Tunnel Creek chipset (3)

[Uwe Hermann]

Hi,

On Mon, Sep 05, 2011 at 09:58:14AM +0200, Feldschmid, Ingo wrote:
> The Intel Tunnel Creek chipset supports both an SPI and an LPC bus.

[...]
> Signed-off-by: Ingo Feldschmid

Thanks a lot for the patch, this is committed with minor changes as r1430.
> /* Enable Flash Writes */
> ret = enable_flash_ich(dev, name, 0xd8);

I added this chunk here, similar to other places which now handle the
return code:

if (ret == ERROR_FATAL)
                return ret;
> /* this adds BUS_SPI */
> buses_supported = BUS_SPI;
> if (ich_init_spi(dev, tmp, rcrb, 7) != 0) {
> if (!ret)
> 	ret = ERROR_NONFATAL;
>    }
>    return ret;

Here we some small whitespace inconsistencies (usage of spaces instead
of one tab for indentation), I fixed those.

Some of the code looks very similar to the one in other functions, maybe
there's some potential for refactoring there, I didn't check closely. If
yes, that can be done in a follow-up patch though.

Cheers, Uwe.