Re: [flashrom] [PATCH 1/3] Factor out SPI write/read chunking wrappers.

[Carl-Daniel Hailfinger]

Am 06.05.2011 12:05 schrieb Michael Karcher:
> Am Donnerstag, den 05.05.2011, 20:47 +0200 schrieb Carl-Daniel
> Hailfinger:
> > > int dummy_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len)
> > >    {
> > >    	return spi_write_chunked(flash, buf, start, len,
> >
> > Any reason you didn't kill dummy_write_256()?
>
> Yes, the reason is that the dummyflasher has a variable maximal chunk
> size specified on the command line, so no constant value can do.

OK.
> Of course patching the programmer structure instead and using the default
> write function is an option.

That would be nice, but it can be done as followup. I'd like to see your 
patch merged ASAP.

Regards,
Carl-Daniel