On 14.05.2010 11:51, Peter Lemenkov wrote:
2010/5/14 Stefan Reinauer stefan.reinauer@coresystems.de:
On 5/14/10 4:00 AM, Carl-Daniel Hailfinger wrote:
libpci < 2.2.4 can not store class info in struct pci_dev. Read class info manually and store it in a separate variable.
Wouldn't it make more sense to ask people to update their libpci? pciutils 2.2.3 is more than 4 years old.
Two reasons for this change: - If we want to get flashrom working with libpayload, we'd better not rely on the more exotic features of libpci because every such feature has to be coded up and I don't think we want to link flashrom-as-payload against the whole libpci. - The enterprise distro problem mentioned below.
It can be very hard - for example in so-called 'enterprise' distributions, which claims API/ABI compatibility as its key feature. Thus sometimes it takes a lot of time to convince maintainer(s) to update package even in case of a minor version upgrade (especially then no bugs were filed against old version of package).
In this case, the patch was motivated by a user request about flashrom on Fedora Core 1 with Linux kernel 2.4. Now if this request had been about removal of C99 constructs, I'd have refused, but an one-liner like the one I sent is IMHO a small price to pay.
Regards, Carl-Daniel