Re: [flashrom] [PATCH] ichspi: Increase timeout to 60s for atomic operations

[Carl-Daniel Hailfinger]

Am 29.04.2011 16:01 schrieb Michael Karcher:
> Signed-off-by: Michael Karcher

Thanks for the patch and for tracking this down and for writing a 
thorough analysis!

Acked-by: Carl-Daniel Hailfinger

Could you fix the whitespace before commit?
> @@ -581,6 +588,7 @@ static int ich7_run_opcode(OPCODE op, uint32_t offset,
>    case 1:
>    	/* Atomic command (preop+op) */
>    	temp16 |= SPIC_ACS;
> timeout = 100 * 1000* 60;	/* 60 seconds */

Should have a space after 1000
> break;
>
> }
>
> @@ -720,6 +734,7 @@ static int ich9_run_opcode(OPCODE op, uint32_t offset,
>    case 1:
>    	/* Atomic command (preop+op) */
>    	temp32 |= SSFC_ACS;
> timeout = 100 * 1000* 60;	/* 60 seconds */

Same here.
> break;
>
> }

Regards,
Carl-Daniel