Am Samstag, den 03.04.2010, 12:08 +0200 schrieb Carl-Daniel Hailfinger:
Remove blockwise write for i82802ab chips. It will be reintroduced in post-0.9.2 in a generic way. This is needed to fix FWH-like chips with non-uniform sectors.
I have modified the changelog a bit.
Fine, adjusted.
Signed-off-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks. Committed in r991
- int shifted = (flash->feature_bits & FEATURE_ADDR_SHIFTED) != 0;
Can we rely on the compiler to set shifted=1 if the feature bit is set?
As discussed on IRC, we can.
- msg_cinfo("Programming page: ");
- for (i = 0; i < flash->total_size; i++) {
You change the write chunk size from page_size to 1024. Does "programming page" still make sense, or should it be "programming chunk at"?
I made it just "programming at".
diff --git a/dmidecode b/dmidecode new file mode 100755 index 0000000..e69de29
Uhhh. Please make sure you don't commit dmidecode by accident.
Thanks for catching that. I swear to never use "add all" again.
.vendor = "Intel",
.name = "28F400BV/CV/CE-B",
Should be ...CE-T unless I'm mistaken.
It should. I fixed it.
A compile test and run test with -p dummy (which triggers the automatic chipdefinition selftest) would be appreciated before committing just to make sure I didn't overlook anything problematic.
Done. Selftest passed.
Regards, Michael Karcher