Re: [flashrom] [PATCH] Add native AAI transfer support to the dediprog driver

[Carl-Daniel Hailfinger]

Am 19.06.2012 09:22 schrieb Nico Huber:
> Hello Carl-Daniel,
>
> Am 19.06.2012 08:44, schrieb Carl-Daniel Hailfinger:
> > > Some compilers might complain about unreachable code in the second if
> > > clause. I think I see what you tried to do here (allow removal of the
> > > first if clause once we know how to handle different chunk sizes), but
>
> Yes, that's what I had in mind.
> > > I'd rather have the second if clause replaced by a comment above the
> > > first if clause. AFAICS code behaviour won't change, and we get
> > > documentation for the 512 byte limit.
>
> Sounds good to me.
>
> Next revision:
>
> This enables native AAI transfer support in the dediprog driver. The
> function to write chunks of data, dediprog_spi_bulk_write(), is reused.
> To tell the programmer how to handle the data on the spi bus, a flag in
> the fourth byte sent with the usb command is used. The second word was
> mistaken for the size of the chunks sent over usb earlier. The third
> byte (first of the second word) is now set to zero. This also adds some
> checks for the size of data chunks sent over usb.
>
> Signed-off-by: Nico Huber

Thank you for the patch.
Acked-by: Carl-Daniel Hailfinger 
and committed in r1546.

Regards,
Carl-Daniel