Re: [flashrom] [PATCH 1/1] Introduce ERROR_FATAL in chipset enables[now really updated]

[Carl-Daniel Hailfinger]

Am 03.09.2011 19:15 schrieb Uwe Hermann:
> On Mon, Aug 22, 2011 at 09:48:10AM +0300, Tadas Slotkus wrote:
> > Currently we are continuing even if chipset enable has failed.
> > Some chipset enables do exits, so to kill those exits I have
> > prepared one sneaky check :) Errors are negative there, so I
> > have chosen this constant.
> >
> > Signed-off-by: Tadas Slotkus
>
> Thanks, r1426 with some small changes. Not sure if we'll keep -0xee as
> error code, this is up for discussion and unification as soon as
> libflashrom gets useful and consistent return codes, I guess.

Ouch, -0xee is the worst error code I ever saw.
> Modified: trunk/chipset_enable.c
>
> --- trunk/chipset_enable.c	Sat Sep  3 13:22:27 2011	(r1425)
> +++ trunk/chipset_enable.c	Sat Sep  3 19:15:00 2011	(r1426)
> @@ -1325,6 +1325,10 @@
>    		msg_pinfo("OK.\n");
>    	else if (ret == ERROR_NONFATAL)
>    		msg_pinfo("PROBLEMS, continuing anyway\n");
> if (ret == ERROR_FATAL) {

Was not using else if here intentional?
> 	msg_perr("FATAL ERROR!\n");
> 	return ret;
> }
>
> }
>
> s = flashbuses_to_text(buses_supported);

Regards,
Carl-Daniel