On Mon, 15 Oct 2012 23:17:44 +0200 Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Probing for AMIC A25L05PT, 64 kB: 3 byte RDID not supported on this SPI controller.
This should have been "4 byte RDID..."
well, when one expects a chip-centric message here (and one probably does, even when the controller is mentioned), then yes. but with my patches that part of the code does not know how many vendor bytes are needed to be read so it checks for down to the minimum of 3 bytes (and prints that then). it was a compromise to make it more generic without more boiler plate code (such as probe_spi_rdid4()). you will see the pros and cons of the approach when you look at the 4th patch more closely. one possible solution for the message itself is to print "RDID with >=i bytes not supported...". in the long term the SPI probing will probably/hopefully change a lot anyway, then this message is no longer relevant anyway.
i'll wait for reviews of the complete set before doing any further changes.