On Fri, Oct 23, 2009 at 02:42:16AM +0200, Carl-Daniel Hailfinger wrote:
On 23.10.2009 01:41, Carl-Daniel Hailfinger wrote:
On 22.10.2009 15:16, Luc Verhaegen wrote:
Also, we are no longer fully on par with the previous board enables which used to touch one bit only per gpio line. Now we touch three. Idwer has a board which requires us to set the first bit (signal to gpio) and the third (gpio level), and it can be forseen that the input/output also needs to be set somewhere in future. Since we need to go through the pain of getting this code tested on a representative subset of this hardware anyway, why not go for a fuller test which will hopefully stand the test of time better?
[...] We need a way to store the signal/direction/level tuple for every GPIO this function is called for, and enable per-GPIO restore. One way would be to have this function keep a list of GPIOs it touched and for every touched GPIO keep the state tuple in a locally allocated data structure. The function would take an additional parameter enum "action": set_bit/clear_bit/restore_bit.
One more thought: Instead of writing the whole tuple without checking the old value, can we add some debugging instead? I.e. printf_debug("Changing signal to GPIO") if the signal was previously set to an alternate function, and being silent in the case where everything is already set up correctly?
Regards, Carl-Daniel
Let's do this afterwards, like some of the other changes suggested which i will go through now.
Luc Verhaegen.