Re: [flashrom] [PATCH] Move serial handling from serprog.c to serial.c

[Uwe Hermann]

On Sat, Nov 21, 2009 at 01:29:11PM +0100, Carl-Daniel Hailfinger wrote:
> Move serial handling from serprog.c to serial.c.
> This is the first step in enabling platform independent serprog and it
> also allows other drivers to use serial port functionality without
> requiring serprog.
>
> Pure code move, no code changed.
>
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Uwe Hermann

Build-tested, worked ok.
> +void __attribute__((noreturn)) sp_die(char *msg)
> +{
> perror(msg);
> exit(1);

EXIT_FAILURE maybe, though I'm not sure we have consistent error codes
everywhere, yet.

Uwe.