Am Mittwoch, den 30.06.2010, 16:29 +0200 schrieb Carl-Daniel Hailfinger:
Comments welcome.
You want to use that for flashrom. Please be advised that superiotool not only contains IDs for Super I/O chips, but also for ECs with a Super I/O-like config space. There are systems with both a Winbond EC and a Winbond Super I/O, one on 0x2E, the other on 0x4E, so there might be more than one match. This is something flashrom is not prepared to handle. If it's just about Super I/O detection, we would need to throw out the non-Super-I/O-containing ECs from the list.
- {0x0581, "F8000", /* Fintek/ASUS F8000 */
LDNDEF({
{EOT}})},
It might be just me, But I don't like the extra line containing just "boilerplate" stuff. Are you geting serious line-length problems with putting LDNDEF also on the first line?
Regards, Michael Karcher