Re: [flashrom] [PATCH 3/3] Warn if running on laptops

[Michael Karcher]

Am Mittwoch, den 24.02.2010, 16:39 +0100 schrieb Carl-Daniel Hailfinger:
> > +	char * chassis_type;
> > char *chassis_type;
> > Changed.
> > +	free (chassis_type);
> > Not sure about the most common coding style. free(object) or free
> > (object). Would be nice to have uniform usage.
> > Changed. You have the space only after keywords.
> > +		       "See http://www.flashrom.org/Supported_hardware#Unsupported_Laptops.2FNotebooks.2FNetbooks\n"
> > Should we point people to http://www.flashrom.org/Laptops instead?
> > Yes, we should.
> Acked-by: Carl-Daniel Hailfinger <[e-mail]>
> Updated patch included, thanks for the ack. Not committed, as it depends
> on the unacked "[PATCH 2/3] Factor out DMI string reading into
> subfunction"

Regards,
  Michael Karcher