Re: [flashrom] [PATCH] Refactor ITE SuperI/O detection/access

[Adrian Glaubitz]

On Mon, Nov 16, 2009 at 2:16 AM, Carl-Daniel Hailfinger
 wrote:
> Refactor ITE SuperI/O detection/access.
> The new code reduces duplications and paves the way for generic SuperI/O
> detection.
> Additional cost: We enter/exit the SuperI/O configuration mode twice.
> Once for detecting which SuperI/O it is, and once for actually changing
> the settings.
> Additional benefit: This has the potential of allowing some sort of
> primitive laptop detection (by way of checking whether an EC or a simple
> SuperI/O is present).
>
> I have added a call to a not yet implemented Winbond SuperI/O detection
> function inside #if 0 to make extension more straighforward.
>
> This affects most SiS chipsets and IT87 SPI translation, so tests in
> verbose mode would be appreciated. In theory, functionality should be
> unchanged.
>
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Adrian Glaubitz <glaubitz at physik.fu-berlin.de>