Re: [flashrom] [PATCH][RFC] Annotate broken boards, mark boards as supported.

[Uwe Hermann]

On Sat, Sep 04, 2010 at 06:06:16PM +0200, Carl-Daniel Hailfinger wrote:
> Success report for Atmel AT26DF081A from
> Oliver Schnatz 
> http://www.flashrom.org/pipermail/flashrom/2009-October/000760.html
>
> Success report for Winbond W25Q32 from
> David Hendricks 
> http://www.flashrom.org/pipermail/flashrom/2010-April/002891.html

I'd use PREW for now where-ever ERASE was successfully tested (even if
only with one of the erase functions) until 0.9.3 is released. Afterwards
merge remaining erase invalidating patches and remove the E bit
from all chips. We do not want to get bombarded with countless
"erase successful" mails after the 0.9.3 release, IMHO, especially as
0.9.3 might end up in various "stable" distro releases and will thus spam
us with such mails for a very long time...
> Success report for SST SST39VF512 from
> Alec Wright 
> http://www.flashrom.org/pipermail/flashrom/2010-August/004549.html

Please also add this URL here for reference:

http://www.flashrom.org/pipermail/flashrom/2010-August/004548.html

And this can also be PREW, see above.
> Success report for Silicon Image SiI 3512 from
> Michael Manulis 
> http://www.flashrom.org/pipermail/flashrom/2010-July/003944.html

Plase also mark the Am29LV040B used in that testrun as PREW.
> To be honest, I'd love to simply remove all "broken" boards without
> findable reports from the list. For all we know, those boards may have
> been tested more than two years ago, and flashrom has added support for
> countless mainboard chipsets, flash translation chips and flash chips
> since then. It is actually pretty likely that most/all of them now work
> fine. If not, we need detailed reports so we can fix them or at least
> find out why they are broken.

Hm, not sure if we should simply remove them, but pinging the users who
own them (if we know those) first would be good. If nobody answers
_and_ we have no real info on the boards, maybe we should drop them from
the list indeed, dunno.
> Maintaining an ever-growing list of "broken" boards without detailed
> information just makes us look bad, and we'll never have a chance to
> find out if the boards are still broken.

Yeah, I agree with the rules below for future board additions.
> I'd also like to set a few rules for future board related patches:
> The changelog should always contain a link to the mail (or
>
> pastebin/whatever) from the reporter. Name alone is not sufficient
> because it makes finding the actual report pretty hard or even impossible.

Yup. I always put in board name, reporter name and email address, and
the URL of the report mail in the mailing list archives, that should
contain all the info we need later to cross-check and track this stuff.
> If the report is about a broken/unsupported board, we additionally
>
> need links to lspci/superiotool results in the changelog, and a link to
> the mailing list post in the board notes in the board table.

Also fine.
> B("ASUS",	"MEW-AM",		0, "ftp://ftp.asus.com.tw/pub/ASUS/mb/sock370/810/mew-am/", NULL),
> B("ASUS",	"MEW-VM",		0, "http://www.elhvb.com/mboards/OEM/HP/manual/ASUS%20MEW-VM.htm", NULL),
> B("ASUS",	"MEW-AM",		0, "ftp://ftp.asus.com.tw/pub/ASUS/mb/sock370/810/mew-am/", "No public report found. May work now."),
> B("ASUS",	"MEW-VM",		0, "http://www.elhvb.com/mboards/OEM/HP/manual/ASUS%20MEW-VM.htm", "No public report found. May work now."),
> B("ASUS",	"P3B-F",		0, "ftp://ftp.asus.com.tw/pub/ASUS/mb/slot1/440bx/p3b-f/", NULL),
> B("ASUS",	"P3B-F",		0, "ftp://ftp.asus.com.tw/pub/ASUS/mb/slot1/440bx/p3b-f/", "No public report found. May work now."),
> B("Biostar",	"M6TBA",		0, "ftp://ftp.biostar-usa.com/manuals/M6TBA/", NULL),
> B("Biostar",	"M6TBA",		0, "ftp://ftp.biostar-usa.com/manuals/M6TBA/", "No public report found. Owned by Uwe Hermann . May work now."),
> B("FIC",	"VA-502",		0, "ftp://ftp.fic.com.tw/motherboard/manual/socket7/va-502/", NULL),
> B("FIC",	"VA-502",		0, "ftp://ftp.fic.com.tw/motherboard/manual/socket7/va-502/", "No public report found. Seems the PCI subsystem IDs are identical with the Tekram P6Pro-A5. May work now."),
> B("MSI",	"MS-6178",		0, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=343", "Immediately powers off if you try to hot-plug the chip. However, this does '''not''' happen if you use coreboot."),
> B("MSI",	"MS-6178",		0, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=343", "Immediately powers off if you try to hot-plug the chip. However, this does '''not''' happen if you use coreboot. Owned by Uwe Hermann ."),
> B("MSI",	"MS-7260, (K9N Neo)",	0, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=255", "Interestingly flashrom does not work when the vendor BIOS is booted, but it ''does'' work flawlessly when the machine is booted with coreboot."),
> B("MSI",	"MS-7260, (K9N Neo)",	0, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=255", "Interestingly flashrom does not work when the vendor BIOS is booted, but it ''does'' work flawlessly when the machine is booted with coreboot. Owned by Uwe Hermann ."),
> B("Soyo",	"SY-5VD",		0, "http://www.soyo.com/content/Downloads/163/&c=80&p=464&l=English", NULL),
> B("Soyo",	"SY-5VD",		0, "http://www.soyo.com/content/Downloads/163/&c=80&p=464&l=English", "No public report found. May work now."),

I own all of the above boards and added the status after testing (a long
time ago) on hardware. I'll try to recheck as many as I can with more
recent flashrom versions and send detailed reports soonish.

For now, feel free to mark them "Owned by Uwe Hermann
." or just leave them unchanged until my reports
come in, your choice.

With the changes above:
Acked-by: Uwe Hermann

Uwe.