Hi Adam,
On 24.11.2009 16:52, Carl-Daniel Hailfinger wrote:
On 24.11.2009 16:46, Adam Jurkowski wrote:
Don't print out supported PCI devices header if all following lines are excluded from build.
Your patch unfortunately conflicts with http://patchwork.coreboot.org/patch/576/ but I'll merge it once that other patch is committed.
The conflicting patch has now been committed. Would you mind regenerating your patch and resending it with the original changelog? I have roughly 50 patches I need to manage and this would reduce my load. Feel free to include my Acked-by statement in your changelog to get a speedier commit.
One minor comment, though. Could you use parentheses like this? #if (NIC3COM_SUPPORT == 1) || (GFXNVIDIA_SUPPORT == 1) || (DRKAISER_SUPPORT == 1) || (SATASII_SUPPORT == 1)
IMHO that makes the code more readable.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel