Author: stefanct Date: Sat Apr 26 18:12:15 2014 New Revision: 1776 URL: http://flashrom.org/trac/flashrom/changeset/1776
Log: CID1130002: Logically dead code due to copy and paste error.
What we really want to do is check whether PCI_BASE_ADDRESS_2 is valid at this point, and not PCI_BASE_ADDRESS_0.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Signed-off-by: Stefan Tauner stefan.tauner@alumni.tuwien.ac.at Acked-by: Stefan Tauner stefan.tauner@alumni.tuwien.ac.at
Modified: trunk/satamv.c
Modified: trunk/satamv.c ============================================================================== --- trunk/satamv.c Sat Apr 26 18:12:03 2014 (r1775) +++ trunk/satamv.c Sat Apr 26 18:12:15 2014 (r1776) @@ -138,7 +138,7 @@ pci_rmmio_writel(tmp, mv_bar + GPIO_PORT_CONTROL);
/* Get I/O BAR location. */ - tmp = pcidev_readbar(dev, PCI_BASE_ADDRESS_2); + addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_2); if (!addr) return 1;
@@ -146,7 +146,7 @@ * FIXME: Check if the I/O BAR is actually reachable. * This is an arch specific check. */ - mv_iobar = tmp & 0xffff; + mv_iobar = addr & 0xffff; msg_pspew("Activating I/O BAR at 0x%04x\n", mv_iobar);
/* 512 kByte with two 8-bit latches, and