[flashrom] Re: Do you have support for W25Q128FW and W25Q256.W?

[David Hendricks]

Hello Amin and Shekar,
It took a while, but I finally received the parts and was able to test them
out on a TInkerboard (RPi-like SBC using linux_spi programmer interface).
The W25Q128FW works in flashrom-v1.2. I also tested a W25Q256JW_DTR
operating in single data rate mode using the master branch and it worked
fine, however it needs the following patch applied:
https://review.coreboot.org/c/flashrom/+/42386

Since there are some Winbond people on this thread, perhaps they can offer
some guidance regarding chip naming. Is there a canonical list of Winbond
devices and their device IDs or some other guidance on naming and device
IDs?

On Wed, Jun 10, 2020 at 6:29 PM Wu, Amin  wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> Add Ryan. 😊
>
> BR
>
> AMIN
>
> *From:* Mike Banon 
> *Sent:* Monday, June 1, 2020 7:20 PM
> *To:* [e-mail]
> *Cc:* [e-mail]; [e-mail]; Wu, Amin ;
> [e-mail]; David Hendricks 
> *Subject:* Re: [flashrom] Re: Do you have support for W25Q128FW and
> W25Q256.W?
>
> [CAUTION: External Email]
>
> Dear Shekar,
>
> I hope that Dave and Amin (and other concerned people subscribed to a
> flashrom mailing list) will test the W25Q128FW and W25Q256.W parts as soon
> as possible and tell the results. Huge benefit of flashrom is that it is
> 100% open source (so much less likely to suffer from bad code quality and
> security issues), and flashrom supports the inexpensive programmers like
> CH341A which costs just $2. The commercial programmers are often expensive
> and have a proprietary closed source software, which is usually bloated,
> may have the security holes (sometimes the deliberate backdoors) and often
> are supported only by Windows OS, so they aren't an option for many people.
> Our goal is to ensure the flashrom's good function in as many use cases and
> for as many parts as possible - and hope that together, with your kind
> help, we will achieve it.
>
> Best regards,
>
> Mike Banon
>
> On Thu, May 28, 2020 at 4:27 AM [e-mail] 
> wrote:
>
> Hi Dave and Amin,
>
> Just following up to ensure this programming issue was resolved at your
> end. Since the newer parts are supported on most commercial programmers and
> we did not hear back from you, we thought you have been able to program the
> parts successfully and have been able to use these parts on the AMD board.
> These parts are already supported on the AMD reference boards with Renoir.
> Thanks.
>
> Regards,
>
> Shekar
>
> *From:* US00 Krishna Shekar
> *Sent:* Friday, May 8, 2020 1:33 PM
> *To:* Mike Banon 
> *Cc:* US40 Jack Lee ; SM10 YLLi5 ;
> Wu, Amin ; [e-mail]; David Hendricks <
> [e-mail]>
> *Subject:* RE: [flashrom] Re: Do you have support for W25Q128FW and
> W25Q256.W?
>
> Copying Dave Hendricks………….
>
> *From:* US00 Krishna Shekar
> *Sent:* Friday, May 8, 2020 1:31 PM
> *To:* Mike Banon 
> *Cc:* US40 Jack Lee ; SM10 YLLi5 ;
> Wu, Amin ; [e-mail]
> *Subject:* RE: [flashrom] Re: Do you have support for W25Q128FW and
> W25Q256.W?
>
> Resending this message with datasheet links below
>
> https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevG%2011252019%20P...
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.winbond.com%2Fresource-files%2FW25Q256JW%2520SPI%2520RevG%252011252019%2520Plus.pdf&data=02%7C01%7CAmin.Wu%40amd.com%7C012fc4d0c44447e8472508d8061dcd03%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637266073433707740&sdata=eZsoLx2%2FxTog0WpX5izBVBCZ9fDa%2B35lQncl4kOoPd8%3D&reserved=0
>
> https://www.winbond.com/resource-files/W25Q128JW_RevD_03132020%20Plus.pdf
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.winbond.com%2Fresource-files%2FW25Q128JW_RevD_03132020%2520Plus.pdf&data=02%7C01%7CAmin.Wu%40amd.com%7C012fc4d0c44447e8472508d8061dcd03%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637266073433707740&sdata=6JeVSOj5qSYRFKUhm%2B97fial5wS7ru17VufXpBwK9Z0%3D&reserved=0
>
> *From:* US00 Krishna Shekar
> *Sent:* Thursday, May 7, 2020 12:14 PM
> *To:* Mike Banon 
> *Cc:* US40 Jack Lee ; SM10 YLLi5 ;
> Wu, Amin ; [e-mail]
> *Subject:* RE: [flashrom] Re: Do you have support for W25Q128FW and
> W25Q256.W?
>
> W25Q128FW and W25Q256FW are older products and have been replaced by the
> latest W25Q128JW and W25Q256JW serial flash products. These newer
> datasheets are publicly available on the Winbond web site www.winbond.com
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.winbond.com%2F&data=02%7C01%7CAmin.Wu%40amd.com%7C012fc4d0c44447e8472508d8061dcd03%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637266073433717740&sdata=RDnaKPTayZ%2BxHMiqbp0bs2BxdLdGD3Q6BDlmToFuKic%3D&reserved=0.
> Please see these datasheets attached. Thanks.
>
> Regards,
>
> Shekar
>
> *From:* Mike Banon [mailto:[e-mail] ]
> *Sent:* Thursday, May 7, 2020 12:01 PM
> *To:* US00 Krishna Shekar 
> *Cc:* US40 Jack Lee ; SM10 YLLi5 ;
> Wu, Amin ; [e-mail]
> *Subject:* Re: [flashrom] Re: Do you have support for W25Q128FW and
> W25Q256.W?
>
> flashrom is really preferable: it's the open source (important!) software
> that supports a lot of programmers, including the inexpensive ones like
> CH341A which costs just $2. To add a support for W25Q128FW and W25Q256FW to
> flashrom - hopefully would be enough to create the correct chip definitions
> in flashchips.c / flashchips.h files using the datasheets for W25Q128FW and
> W25Q256FW. If these datasheets aren't publicly available yet, please
> provide them.
>
> On Thu, May 7, 2020 at 4:23 PM [e-mail] 
> wrote:
>
> Hi Everyone,
>
> The latest part numbers I would recommend your using are W25Q128JWSSIQ or
> W25Q128JWEIQ (128Mb serial flash) and W25Q256JWEIQ (256Mb serial flash) on
> your designs. The part numbers mentioned below are old parts and the part
> numbers are incomplete. The part numbers I have mentioned are supported on
> the AMD Renoir reference boards, and in turn supports all the CPUs that AMD
> offers today. If you have further questions about support for AMD products,
> please contact Jason Hawken at AMD, Toronto.
>
> I am not sure if these are supported on Raspberry. Please take a look at
> the link below to look at the support provided by several programmer
> vendors for Winbond flash parts.
>
> https://www.winbond.com/resource-files/AN0000012%20CodeStorageMemoryProgramm...
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.winbond.com%2Fresource-files%2FAN0000012%2520CodeStorageMemoryProgrammingSupport%2520Guide%2520v4.2%252002282020.pdf&data=02%7C01%7CAmin.Wu%40amd.com%7C012fc4d0c44447e8472508d8061dcd03%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637266073433717740&sdata=0%2Bk0FpMxEwAJlPqi9qe4769go7taH3dhjaHGBlN6uwo%3D&reserved=0
>
> I would recommend using Dediprog programmers - You are likely to find good
> support on Dediprog programmers for Winbond parts.
>
> If you already have the W25Q128FW and W25Q256FW parts with you now, they
> are supported on the Dediprog programmers as well. Trust this information
> is helpful. Let us know if you need any further help. Thanks.
>
> Regards,
>
> Shekar
>
> *From:* US40 Jack Lee
> *Sent:* Wednesday, May 6, 2020 7:42 PM
> *To:* SM10 YLLi5 ; Wu, Amin ; US00
> Krishna Shekar 
> *Cc:* David Hendricks ; [e-mail]
> *Subject:* Re: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> Hi Shekar,
>
> Please help and feedback.
>
> Thx.
> Jack
>
> *From:* SM10 YLLi5 
> *Sent:* Wednesday, May 6, 2020 7:40 PM
> *To:* Wu, Amin; US40 Jack Lee
> *Cc:* David Hendricks; [e-mail]
> *Subject:* FW: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> Hi Jack,
>
> Here we have the question below. do you mind to answer for this? Thanks.
>
> Do you have a plan to support flash bios for W25Q128FW and W25Q256.W via
> flashrom in Raspberry?
>
> Regards,
>
> Yulia
>
> *From:* Wu, Amin [mailto:[e-mail] ]
> *Sent:* Thursday, May 07, 2020 10:38 AM
> *To:* SM10 YLLi5; David Hendricks
> *Cc:* [e-mail]
> *Subject:* RE: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Thanks David.
>
> I tried flashrom1.2 , W25Q128FW and W25Q256.W are not in the support list.
>
> I want use Raspberry only to flash W25Q128FW and W25Q256.W.
>
> Hi Yulia,
>
> Can you add W25Q128FW and W25Q256.W to flashrom support list to use
> Raspberry only? Thanks for your responding.
>
> BR
>
> AMIN
>
> *From:* Yulia Li 
> *Sent:* Thursday, May 7, 2020 10:22 AM
> *To:* David Hendricks ; Wu, Amin <
> [e-mail]>
> *Cc:* [e-mail]
> *Subject:* RE: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> [CAUTION: External Email]
>
> Hi Amin,
>
> Sorry for the late reply, do you still need any other support?
>
> Thanks.
>
> Regards,
>
> Yulia
>
> *From:* David Hendricks [mailto:[e-mail]
> ]
> *Sent:* Saturday, April 25, 2020 12:02 PM
> *To:* Wu, Amin
> *Cc:* AP A0PH mkt_online; [e-mail]
> *Subject:* Re: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> Hi Amin,
>
> Please note that the W25Q128FW is a 1.8V chip, while Raspberry PI IOs are
> 3.3V.
>
> For Dediprog, pass in the `voltage` parameter, e.g. `flashrom -p
> dediprog:voltage=1.8 -r foo.bin`
>
> Also, as Mike mentioned it will help if we know the version of flashrom
> which you are trying to use. Some distributions provide very old versions.
>
> On Wed, Apr 22, 2020 at 1:33 AM Wu, Amin  wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi David Hendricks,
>
> “No EEPROM/flash device found” pop after I added below code to
> flashchips.c and flashchips.h to install flashrom in Raspberry 4B.
>
> pi@raspberrypi:~ $ sudo flashrom -p
> linux_spi:dev=/dev/spidev0.0,spispeed=4096
>
> flashrom  on Linux 4.19.57-v7l+ (armv7l)
>
> flashrom is free software, get the source code at https://flashrom.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fflashrom.org%2F&data=02%7C01%7CAmin.Wu%40amd.com%7C012fc4d0c44447e8472508d8061dcd03%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637266073433727731&sdata=yrUuSt5CYiF0l5341dqBuRsOTbBuiD7FRozrFYy6t94%3D&reserved=0
>
> Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
>
> No EEPROM/flash device found.
>
> Note: flashrom can never write if the flash chip isn't found automatically.
>
> Do you have any suggestions? Thanks 😊
>
> flashchips.h
>
> #define WINBOND_NEX_W25Q128FW 0xef6018 /*W25Q128FW */
>
> flashchips.c
>      {
>
>               .vendor            = "Winbond",
>
>               .name               = "W25Q128FW",
>
>               .bustype  = BUS_SPI,
>
>               .manufacture_id     = WINBOND_NEX_ID,
>
>               .model_id        = WINBOND_NEX_W25Q128FW,
>
>               .total_size       = 16384,
>
>               .page_size       = 256,
>
>               /* supports SFDP */
>
>               /* OTP: 1024B total, 256B reserved; read 0x48; write
>
> 0x42, erase 0x44, read ID 0x4B */
>               .feature_bits   = FEATURE_WRSR_WREN | FEATURE_OTP |
>
> FEATURE_QPI,
>               .tested              = TEST_OK_PREW,
>
>               .probe              = probe_spi_rdid,
>
>               .probe_timing = TIMING_ZERO,
>
>               .block_erasers =
>
>               {
>
>                       {
>
>                                .eraseblocks = { {4 * 1024, 4096} },
>
>                                .block_erase = spi_block_erase_20,
>
>                       }, {
>
>                                .eraseblocks = { {32 * 1024, 512} },
>
>                                .block_erase = spi_block_erase_52,
>
>                       }, {
>
>                                .eraseblocks = { {64 * 1024, 256} },
>
>                                .block_erase = spi_block_erase_d8,
>
>                       }, {
>
>                                .eraseblocks = { {16 * 1024 * 1024, 1}
>
> },
>                                .block_erase = spi_block_erase_60,
>
>                       }, {
>
>                                .eraseblocks = { {16 * 1024 * 1024, 1}
>
> },
>                                .block_erase = spi_block_erase_c7,
>
>                       }
>
>               },
>
>               .printlock = spi_prettyprint_status_register_plain, /*
>
> TODO: improve */
>               .unlock             = spi_disable_blockprotect,
>
>               .write                = spi_chip_write_256,
>
>               .read                 = spi_chip_read,
>
>               .voltage   = {1650, 1950},
>
>      },
>
>
>
>
>
> BR
>
> AMIN
>
> *From:* Wu, Amin
> *Sent:* Wednesday, April 22, 2020 2:55 PM
> *To:* 'David Hendricks' ; '
> [e-mail]' 
> *Cc:* '[e-mail]' 
> *Subject:* RE: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Winbond,
>
> Do you have a plan to support flash bios for W25Q128FW and W25Q256.W via
> flashrom in Raspberry?
>
> BR
>
> AMIN
>
> *From:* Wu, Amin
> *Sent:* Tuesday, April 21, 2020 1:32 PM
> *To:* David Hendricks 
> *Cc:* [e-mail]
> *Subject:* RE: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi David, Hendricks,
>
> Can you share the flashrom link to download which support W25Q128FW and
> W25Q256.W?
>
> Now I used DediProg to flash these bioschip. I can try with raspberry to
> flash when I get the flashrom from you. 😊
>
> It is great help for me if flashrom support W25Q128FW and W25Q256.W. I
> tried edit flashchip.c and flashchip.h, but flash fail and fail. ☹
>
> Thank you flashrom developer. Good job! Flashrom~Yes~
>
> BR
>
> AMIN
>
> *From:* David Hendricks 
> *Sent:* Tuesday, April 21, 2020 1:06 PM
> *To:* Wu, Amin 
> *Cc:* [e-mail]
> *Subject:* Re: [flashrom] Do you have support for W25Q128FW and W25Q256.W?
>
> [CAUTION: External Email]
>
> Yes and yes :-)
>
> On Mon, Apr 20, 2020 at 10:05 PM Wu, Amin  wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi
>
> Do you have support for W25Q128FW and W25Q256.W? Thanks
>
> BR
>
> AMIN
>
> flashrom mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
>
> The privileged confidential information contained in this email is
> intended for use only by the addressees as indicated by the original sender
> of this email. If you are not the addressee indicated in this email or are
> not responsible for delivery of the email to such a person, please kindly
> reply to the sender indicating this fact and delete all copies of it from
> your computer and network server immediately. Your cooperation is highly
> appreciated. It is advised that any unauthorized use of confidential
> information of Winbond is strictly prohibited; and any information in this
> email irrelevant to the official business of Winbond shall be deemed as
> neither given nor endorsed by Winbond.
>
> The privileged confidential information contained in this email is
> intended for use only by the addressees as indicated by the original sender
> of this email. If you are not the addressee indicated in this email or are
> not responsible for delivery of the email to such a person, please kindly
> reply to the sender indicating this fact and delete all copies of it from
> your computer and network server immediately. Your cooperation is highly
> appreciated. It is advised that any unauthorized use of confidential
> information of Winbond is strictly prohibited; and any information in this
> email irrelevant to the official business of Winbond shall be deemed as
> neither given nor endorsed by Winbond.
>
> flashrom mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
>
> The privileged confidential information contained in this email is
> intended for use only by the addressees as indicated by the original sender
> of this email. If you are not the addressee indicated in this email or are
> not responsible for delivery of the email to such a person, please kindly
> reply to the sender indicating this fact and delete all copies of it from
> your computer and network server immediately. Your cooperation is highly
> appreciated. It is advised that any unauthorized use of confidential
> information of Winbond is strictly prohibited; and any information in this
> email irrelevant to the official business of Winbond shall be deemed as
> neither given nor endorsed by Winbond.