[flashrom] W29EE011-15 (was: Hello, Support for Atmel's AT25F series and some small stuff)

[Stefan Tauner]

On Mon, 14 Mar 2011 22:29:56 +0100
Carl-Daniel Hailfinger  wrote:
> I will review the patches individually, but a small comment
> beforehand: There are some pending patches for AT25* already, and we
> should make sure to avoid conflicts between those patches and your
> patches. I'll dig up those AT25* patches again and repost them for
> review. Given that you looked at AT25* in detail, maybe you can
> review those older AT25 changes?

i have only looked at AT25F*, but yes sure i can...

i started to test my old bios/etherboot chips. sadly i had to notice
that the 3com nics i gathered for this (already marked to be ok) only
support 128kB and most of the chips are 256kB. btw this would be
something i'd like to be reported in the wiki list.
anyway... there is one 128kB chip and this might be quite interesting
to play with... because there seem to be some serious wtf in the
codebase. at least i dont understand it.
the chip is a W29EE011-15.
it uses the WINBOND_W29C010 define and there are two elements in the
flashchips.c table that use them, both with the name
"W29C010(M)/W29C011A/W29EE011/W29EE012". they only differ in their
probing function which was modified because of problems with A49LF040A
(http://www.mail-archive.com/[e-mail]/msg02644.html).

i did not dig into the revision history but it seems someone missed
some side effects when merging the chips or so (after r1091:
http://www.flashrom.org/pipermail/flashrom/2010-August/004345.html).

executing ./flashrom -V -p nic3com -c
"W29C010(M)/W29C011A/W29EE011/W29EE012" results in:
...
Initializing nic3com programmer
Found "3COM 3C90xB: PCI 10/100 Mbps; shared 10BASE-T/100BASE-TX" (10b7:9055, BDF 01:00.0).
Requested BAR is I/O
Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: probe_jedec_common: id1 0xda, id2 0xc1
Found chip "Winbond W29C010(M)/W29C011A/W29EE011/W29EE012" (128 kB, Parallel) on nic3com.
Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: Probing disabled for Winbond W29EE011 because the probing sequence puts the AMIC A49LF040A in a funky state. Use 'flashrom -c W29EE011' if you have a board with this chip.
...

the message suggesting 'flashrom -c W29EE011' is not even correct
since this would fail with:
Error: Unknown chip 'W29EE011' specified.

if no one can shed some light on this, i would suggest that we
remove the alternative probing because jedec works for me (tested
PR only yet).