Re: [flashrom] [PATCH] Portability fixes

[Carl-Daniel Hailfinger]

Am 31.07.2012 02:41 schrieb Jonathan A. Kollasch:
> On Mon, Jul 23, 2012 at 02:48:40AM +0200, Carl-Daniel Hailfinger wrote:
> > Build ich_descriptors_tool by default on x86. (Patch by Stefan Tauner)
> > +ifeq ($(ARCH), x86)
> > @+make -C util/ich_descriptors_tool/ TARGET_OS=$(TARGET_OS) EXEC_SUFFIX=$(EXEC_SUFFIX)
> >
> > +endif
> >
> > $(PROGRAM)$(EXEC_SUFFIX): $(OBJS)
> >    $(CC) $(LDFLAGS) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(FEATURE_LIBS) $(LIBS)
> >
> > @@ -569,6 +607,7 @@
> >  # We don't use EXEC_SUFFIX here because we want to clean everything.
> >  clean:
> >    rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a *.o *.d
> > @+make -C util/ich_descriptors_tool/ clean
>
> This will invoke a non-GNU make on at least some non-GNU platforms, such
> as the various BSDs.  Please use "$(MAKE)" instead of "make".

Thanks, fixed locally.

Regards,
Carl-Daniel