Re: [flashrom] [PATCH] Kill hardcoded block erase on ICH SPI

[Maciej Pijanka]

On Mon, 23 Nov 2009, Carl-Daniel Hailfinger wrote:
> Kill hardcoded block erase on ICH SPI.
> The existing code does not work for all SPI chips, and it just was a
> band-aid to cope with locked down chipsets back in a time when there was
> no eraseblock infrastructure.
> Basically, this unbreaks a few SPI chips on ICH.

Looks sane for me, but i don't have any ICH/SPI hardware to check, idea seems
to be right too, because it replace hardcoded one-of-erase-types with chip-based
erase.

Acked-by: Maciej Pijanka
> Signed-off-by: Carl-Daniel Hailfinger
> Index: flashrom-ich_spi_no_hardcoded_block_erase/ichspi.c
>
> --- flashrom-ich_spi_no_hardcoded_block_erase/ichspi.c	(Revision 769)
> +++ flashrom-ich_spi_no_hardcoded_block_erase/ichspi.c	(Arbeitskopie)