Re: [flashrom] [PATCH] Add struct flashctx * everywhere

[Carl-Daniel Hailfinger]

Am 18.12.2011 13:57 schrieb Michael Karcher:
> Am Freitag, den 16.12.2011, 14:41 +0100 schrieb Carl-Daniel Hailfinger:
> > No functional changes. Please test anyway on real hardware.
>
> flashrom -r works on my laptop (ICH7, SPI)
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Michael Karcher

Thanks for the review and test!
Committed in r1474.
> One remark: You might consider to split chip_{read,write}{b,l,w} into
> chip_data_{read,write}{b,l,w} and chip_reg_{read,write}{b,l,w} and
> implicitly add "virtual_memory" or "virtual_registers" to the address
> space offset passed to the new functions (for the case of registers and
> data mapped into the same address space, so one chip_read/write family
> is usefull at all).
>
> The upside of the proposal is that we get rid of all the
> "flash->virtual_memory + " additions scattered over all chip driver, the
> downside is yet another layer of indirection.

I really like this proposal.
> Thank you for all this tedious mechanical work on the patch,

Thank you for reviewing such a megapatch. My apologies for the broken
interdiff.

Regards,
Carl-Daniel