Re: [flashrom] [PATCH] Refactor remaining write wrappers

[Sean Nelson]

On 10/11/10 5:35 AM, Carl-Daniel Hailfinger wrote:
> On 10.10.2010 15:19, Uwe Hermann wrote:
> > On Sat, Oct 09, 2010 at 11:59:24PM +0200, Carl-Daniel Hailfinger wrote:
> > > Refactor remaining write wrappers.
> > > Kill duplicated code.
> > >
> > > Signed-off-by: Carl-Daniel Hailfinger
> >
> > Acked-by: Uwe Hermann
>
> Thanks for the review. Here is an extended patch which has some more
> refactoring to make the switchover to partial write less painful. Parts
> have already been reviewed by Uwe.
>
> If possible, please test this code on all chip classes, one per write
> function listed below.
> write_82802ab()
> write_jedec()
> write_jedec_1()
> write_m29f400bt()
> write_28sf040()
>
> Testing of SPI chips is not needed. They are not touched in this patch.
>
> Refactor remaining write wrappers.
> Kill duplicated code.
> Annotate write functions with their chunk size.
> Mark Fujitsu MBM29F400BC and ST M29F400BB as untested because their
> write code no longer uses a broken layout.
>
> Signed-off-by: Carl-Daniel Hailfinger

Tested on hardware.
Acked-by: Sean Nelson