Re: [flashrom] [PATCH] Add SPI multicommand infrastructure

[Jakob Bornecrantz]

On Fri, Jul 10, 2009 at 10:15 PM, Carl-Daniel
Hailfinger wrote:
> Add SPI multicommand infrastructure.
>
> Some SPI opcodes need to be sent in direct succession after each other
> without any chip deselect happening in between. A prominent example is
> WREN (Write Enable) directly before PP (Page Program). Intel calls the
> first opcode in such a row "preopcode".
>
> Right now, we ignore the direct succession requirement completely and it
> works pretty well because most onboard SPI masters have a timing or
> heuristics which make the problem disappear.
> The FT2232 SPI flasher is different. Since it is an external flasher,
> timing is very different to what we can expect from onboard flashers and
> this leads to failure at slow speeds.
>
> This patch allows any function to submit multiple SPI commands in a
> stream to any flasher. Support in the individual flashers isn't
> implemented yet, so there is one generic function which passes the each
> command in the stream one-by-one to the command functions of the
> selected SPI flash driver.
>
> Signed-off-by: Carl-Daniel Hailfinger

Thanks for sending this out.

I only tested reading with the external program but it works as in the
past. And going over the code it looks good as well.

Acked-by: Jakob Bornecrantz 
Tested-by: Jakob Bornecrantz

[SNIP]

Cheers Jakob.