Re: [flashrom] [PATCH] Use slow toggle for erase, debug excessive delay

[Carl-Daniel Hailfinger]

On 16.12.2009 12:53, Michael Karcher wrote:
> Am Mittwoch, den 16.12.2009, 02:26 +0100 schrieb Carl-Daniel Hailfinger:
> > The Winbond W39V040C requires a 50 ms delay between toggle bit reads
> > during erase according to the datasheet. Turns out a 2 ms delay is
> > sufficient. Use a safety factor of 4 and default all erase operations to
> > 8 ms delay between toggle reads. This is short enough not to have a
> > substantial negative impact on erase times, and should improve reliability.
>
> While your patch looks OK, I somehow dislike your comment.

I have reworked the changelog to address your concerns. Thanks for the
detailed review.
> Acked-By: Michael Karcher

Thanks, r807.

Regards,
Carl-Daniel