Re: [flashrom] [PATCH] Hook up SPI unlock to infrastructure

[Carl-Daniel Hailfinger]

On 11.07.2010 09:17, Michael Karcher wrote:
> Am Sonntag, den 11.07.2010, 00:56 +0200 schrieb Carl-Daniel Hailfinger:
> > We have a generic unlocking infrastructure. Use it for SPI chips.
> > Actually check if the unlock worked instead of just assuming it worked.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Michael Karcher

Thanks, will commit once [PATCH] Convert SPI chips to partial write is in.
> > @@ -196,8 +196,6 @@
> >  /*
> > Program chip using page (256 bytes) programming.
> > Some SPI masters can't do this, they use single byte programming instead.
> > The redirect to single byte programming is achieved by setting
> > .write_256 = spi_chip_write_1
> > */
> >
> > /* real chunksize is up to 256, logical chunksize is 256 */
> >  int spi_chip_write_256_new(struct flashchip *flash, uint8_t *buf, int start, int len)
>
> Just tell me to learn reading!

I added that comment after you complained about a lack of clarity, so
your reading skills are beyound doubt. This hunk should not have been
marked as deletion, it was added in some other patch. Maybe I screwed up
the diff command.
> The comment explicitly says how the
> redirection happens, please leave it in, it was good.

Sure, will do.

Regards,
Carl-Daniel