Re: [flashrom] [PATCH] eliminate magic numbers indicating maximum column sizes in print_supported_chipsets and print_supported_boards_helper

[Stefan Tauner]

On Thu, 26 May 2011 01:34:28 +0200
Carl-Daniel Hailfinger  wrote:
> Am 25.05.2011 18:19 schrieb Stefan Tauner:
> > On Tue, 24 May 2011 09:01:13 +0200 Carl-Daniel Hailfinger wrote:
> > > Am 24.05.2011 02:21 schrieb Stefan Tauner:
> > > > int status;
> > > > int status; /* OK=0 and NT=1 are defines only. Beware! */
> > >
> > > Do we want an enum instead?
> >
> > i like strong types, but i dont care too much in this case.
>
> If we use an enum here, we should also use an enum everywhere else for
> tested/untested.

besides being work, this does not sound as being a bad thing to me
(yet) :)
> Looks good, thanks for addressing the review comments. I assume you
> tested that the output still looks OK and that it compiles.
> Acked-by: Carl-Daniel Hailfinger
>
> Please go ahead and commit.

thanks, r1318