Re: [flashrom] [PATCH] Standardize on using __func__ instead of __FUNCTION__

[Uwe Hermann]

On Wed, Sep 02, 2009 at 06:23:07PM +0200, Stefan Reinauer wrote:
> Uwe Hermann wrote:
> > See patch.
>
> For all debugging messages:
> Acked-by: Stefan Reinauer

Thanks, r711.
> But this:
> > Index: ft2232_spi.c
> >
> > --- ft2232_spi.c	(Revision 710)
> > +++ ft2232_spi.c	(Arbeitskopie)
> > @@ -285,7 +285,7 @@
> >    		l = total_size - i;
> >    	if ((r = spi_nbyte_program(i, &buf[i], l))) {
> > 	fprintf(stderr, "%s: write fail %d\n", __FUNCTION__, r);
> > 	fprintf(stderr, "%s: write fail %d\n", __func__, r);
> > return 1;
> > }
>
> Error messages (ie. not _debugging_ messages) should not contain
> function names and numbers but descriptive error messages.

Agreed, this is for another patch, though.

Uwe.