Re: [flashrom] [PATCH] Improve error messages, protect the user

[Stefan Reinauer]

On 8/12/09 2:06 PM, Carl-Daniel Hailfinger wrote:
> if (verify_it) {
> /* Work around chips which need some time to calm down. */
> if (write_it)
> 	programmer_delay(1000*1000);
> ret = verify_flash(flash, buf);
> if (ret)
> 	emergency_help_message();
> }

This should be

/* If we tried to write, and now we don't properly verify, we might have
an emergency situation */
if (write_it && ret)
    emergency_help_message();

Otherwise

Acked-by: Stefan Reinauer