Hi Edward,
could we instead of removing it convert it into its own programmer? Renaming the wbsio_check_for_spi to wbsio_init and add a allow_brick=yes parameter.
This should allow you to move forward and also keep the code?
-- Thomas
On Mon, 2023-02-06 at 12:23 +1100, Edward O'Callaghan via flashrom wrote:
G'day flashrom'ers,
Does anyone use or still need the wbsio spi path specifically used for the Intel D201GLY board? I wish to remove this code https://review.coreboot.org/c/flashrom/+/72828 if at all possible.
The reasoning is that a lot of board_enable changes would be required to allow for the drivers entry-point to be passed configuration and other data. The driver is a single exception to every other driver in the tree that either has a direct driver entry from the driver table (programmer_table) or via the specalised "internal" programmer that directs entry via a chipset_enable dispatch. It would be preferably for board_enable not to have a deep CFG going right though it to driver entry-points for one very specific case especially if the driver isn't even used anymore?
Interested to hear your thoughts or users? Cheers, Edward. _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-leave@flashrom.org