Re: [flashrom] Flashrom on Gigabyte GA-MA770-UD3 (rev 1.0) - works with little patch

[Carl-Daniel Hailfinger]

On 29.03.2010 06:06, Vadim Girlin wrote:
> Signed-off-by: Vadim Girlin

Thanks!
I have added one diagnostic message to flashrom to notify users that
IT87 SPI is overriding the chipset SPI controller and downgraded one
message from info to debug.

My changes are
Signed-off-by: Carl-Daniel Hailfinger

Your patch is
Acked-by: Carl-Daniel Hailfinger

Thanks to Sean Nelson for an informal review of my changes.

Here is the combined patch for reference:

Index: flashrom-it87spi_it8720/it87spi.c
===================================================================
--- flashrom-it87spi_it8720/it87spi.c	(Revision 988)
+++ flashrom-it87spi_it8720/it87spi.c	(Arbeitskopie)
@@ -103,6 +103,7 @@
    switch (id) {
    case 0x8716:
    case 0x8718:
+	case 0x8720:
    	enter_conf_mode_ite(port);
    	/* NOLDN, reg 0x24, mask out lowest bit (suspend) */
    	tmp = sio_read(port, 0x24) & 0xFE;
@@ -159,7 +160,7 @@
    	break;
    /* TODO: Handle more IT87xx if they support flash translation */
    default:
-		msg_pinfo("SuperI/O ID %04hx is not on the controller list.\n", id);
+		msg_pdbg("SuperI/O ID %04hx is not on the controller list.\n", id);
    }
    return flashport;
 }
@@ -199,8 +200,11 @@
    int ret;

ret = it87spi_common_init();
-	if (!ret)
+	if (!ret) {
+		if (buses_supported & CHIP_BUSTYPE_SPI)
+			msg_pdbg("Overriding chipset SPI with IT87 SPI.\n");
    	buses_supported |= CHIP_BUSTYPE_SPI;
+	}
    return ret;
 }

Committed in r989.

Regards,
Carl-Daniel