Re: [flashrom] [PATCH] Autodetect target processor architecture

[Carl-Daniel Hailfinger]

Autodetect target processor architecture.
Enable architecture dependent compilation of individual sub-drivers for
the internal programmer.

With this patch, you no longer have to edit the Makefile to compile the
internal driver on MIPS/ARM/...

David: This one should take care of the Makefile hacks you needed.

Am 29.06.2011 04:26 schrieb Carl-Daniel Hailfinger:
> TODO: arch.h is not suitable for inclusion in a .c/.h file because of
> its last line. Any ideas how to change that (move arch.h as "here
> document" into the Makefile, use other trickery like more #ifdefs)?

Various solutions have been suggested, and the consensus seemed to be
that we need to make a generic decision about where to store all those
compilation tests in the Makefile, but that it should not happen in this
patch.

Signed-off-by: Carl-Daniel Hailfinger

Index: flashrom-target_arch/Makefile
===================================================================
--- flashrom-target_arch/Makefile	(Revision 1357)
+++ flashrom-target_arch/Makefile	(Arbeitskopie)
@@ -37,7 +37,10 @@
 CFLAGS += -Werror
 endif

-# FIXME We have to differentiate between host and target arch.
+# Determine the destination processor architecture
+ARCH = $(strip $(shell LC_ALL=C gcc -E arch.h|grep -v '^#'))
+
+# FIXME We have to differentiate between host and target OS architecture.
 OS_ARCH	?= $(shell uname)
 ifneq ($(OS_ARCH), SunOS)
 STRIP_ARGS = -s
@@ -222,8 +225,10 @@
 ifeq ($(CONFIG_INTERNAL), yes)
 FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1'
 PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o dmi.o internal.o
-# FIXME: The PROGRAMMER_OBJS below should only be included on x86.
+ifeq ($(ARCH),"x86")
 PROGRAMMER_OBJS += it87spi.o it85spi.o ichspi.o sb600spi.o wbsio_spi.o mcp6x_spi.o
+else
+endif
 NEED_PCI := yes
 endif

@@ -418,6 +423,11 @@
    	echo "found." || ( echo "not found."; \
    	rm -f .test.c .test$(EXEC_SUFFIX); exit 1)
    @rm -f .test.c .test$(EXEC_SUFFIX)
+	@printf "ARCH is "
+	@# FreeBSD wc will output extraneous whitespace.
+	@echo $(ARCH)|wc -l|grep -q '^[[:blank:]]*1[[:blank:]]*$$' ||	\
+		( echo "unknown. Aborting."; exit 1)
+	@printf "%s\n" '$(ARCH)'

ifeq ($(CHECK_LIBPCI), yes)
 pciutils: compiler
Index: flashrom-target_arch/arch.h
===================================================================
--- flashrom-target_arch/arch.h	(Revision 0)
+++ flashrom-target_arch/arch.h	(Revision 0)
@@ -0,0 +1,31 @@
+/*
+ * This file is part of the flashrom project.
+ *
+ * Copyright (C) 2011 Carl-Daniel Hailfinger
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+/*
+ * Header file for CPU architecture checking.
+ */
+
+#if defined (__i386__) || defined (__x86_64__)
+#define __FLASHROM_ARCH__ "x86"
+#elif defined (__mips) || defined (__mips__) || defined (_mips) || defined (mips)
+#define __FLASHROM_ARCH__ "mips"
+#elif defined(__powerpc__) || defined(__powerpc64__) || defined(__ppc__) || defined(__ppc64__)
+#define __FLASHROM_ARCH__ "ppc"
+#endif
+__FLASHROM_ARCH__