Am Donnerstag, den 01.07.2010, 17:32 +0200 schrieb Carl-Daniel Hailfinger:
This feature will be used by the Nvidia MCP SPI code, and it also might make sense for the gfxnvidia driver which has non-working write/erase.
The feature looks good, but...
+/* Is writing allowed with this programmer? */ +int programmer_may_write = 1;
... libflashrom guys are going to hate you for another global variable, I guess. And they *will* hate you for statically initialized global variables, because if a GUI wants to flash twice, and the first attempt sets programmer_may_write to zero, the second flashing process will also run into the "you don't want to write" test. Can't you set this variable to 1 at the top of the generic programmer_init function?
This patch (and a patch dynamically initializing the variable at said point in code) are
Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Regards, Michael Karcher