Re: [flashrom] [PATCH] Boards: Unify all intel ICH GPIO raising.

[Carl-Daniel Hailfinger]

On 25.10.2009 03:48, Luc Verhaegen wrote:
> On Sun, Oct 25, 2009 at 02:50:03AM +0200, Uwe Hermann wrote:
> > On Sat, Oct 24, 2009 at 12:42:21AM +0200, Luc Verhaegen wrote:
> > > return ich_gpio_raise(name, 0x8086, 0x2640, 0x48, 0x0c, 0xffc0, 19);
> > > struct pci_dev *dev;
> > > dev = pci_dev_find(0x8086, 0x2640);	/* Intel ICH6 LPC Interface */
> > > if (!dev) {
> > > fprintf(stderr, "\nERROR: Intel ICH9R LPC not found.\n");
> >
> > One comment says ICH6, the other ICH9R. One of them is wrong.
>
> Oh please.

Actually, this is the reason why I didn't want chipset names in board
enable functions. It's so easy to get them wrong when using cut-n-paste.

Regards,
Carl-Daniel