Re: [flashrom] [PATCH] Intel chip id fix-up (ver 3)

[Mattias Mattsson]

On Tue, Oct 5, 2010 at 15:23, Carl-Daniel Hailfinger
 wrote:
> On 15.09.2010 01:41, Mattias Mattsson wrote:
> > This is a new version of an earlier patch.
> >
> > Make sure all chip variants are present in .name strings in flashchips.c
> >
> > Strip package prefix in constant names (everything before "28F").
> >
> > Prefix every constant name with INTEL_
> >
> > Sort intel chip constants by id.
> >
> > Rename the following constants to their "canonical" name:
> >
> > P28F400BT (0x70)
> >  -> INTEL_28F400T (28F400BV/BX/CE/CV-T)
> >
> > P28F400BB (0x71)
> >  -> INTEL_28F400B (28F400BV/BX/CE/CV-B)
> >
> > P28F004BT (0x78)
> >  -> INTEL_28F004T (28F004B5/BE/BV/BX-T)
> >
> > P28F004BB (0x79)
> >  -> INTEL_28F004B (28F004B5/BE/BV/BX-B)
> >
> > E_28F008S5 (0xA6)
> >  -> INTEL_28F008S3 (28F008S3/S5/SC)
> >
> > E_28F004S5 (0xA7)
> >  -> INTEL_28F004S3 (28F008S3/S5/SC)
> >
> > P28F001BXT (0x94)
> >  -> INTEL_28F001T (28F001BN/BX-T)
> >
> > P28F001BXB (0x95)
> >  -> INTEL_28F001B (28F001BN/BX-B)
> >
> > E_28F016S5 (0xAA)
> >  -> INTEL_28F016S3 (28F016S3/S5/SC)
>
> Can you change the text above to the form
>
> P28F400BT (0x70) -> INTEL_28F400T (28F400BV/BX/CE/CV-T)
>
> and remove the empty lines in between? That would shorten the changelog.

Fixed.
> > Also add chip ids for the following chips:
> >
> > 28F320J5
> > 28F640J5
> > 28F320J3
> > 28F640J3
> > 28F128J3
> > 28F256J3
> > 28F200BL/BV/BX/CV-T
> > 28F200BL/BV/BX/CV-B
> > 28F002BL/BV/BX-B
> > 28F008BE/BV-T
> > 28F008BE/BV-B
> > 28F800B5/BV/CE/CV-T
> > 28F800B5/BV/CE/CV-B
> > 28F016SA/SV
> > 28F008SA
> > 28F008S3/S5/SC
> > 28F008S3/S5/SC
> > 28F016XS
> > 28F010
> > 28F512
> > 28F256A
> > 28F020
> > 28F016B3-T
> > 28F016B3-B
> > 28F008B3-T
> > 28F008B3-B
> > 28F004B3-T
> > 28F004B3-B
> >
> > Signed-off-by: Mattias Mattsson
>
> I want this for 0.9.3.
>
> Acked-by: Carl-Daniel Hailfinger

Thanks, committed as r1189.

-mattias