I'd like to start experimenting with partial-write support, now that partial-read works well for me. But as of now doit() does a full read before the write, which of course fails. Any updates that I could test? Any useful log I can provide regarding successes?
Note, I now have a buspirate so I can do full writes to recover, as needed (this works successfully now, if slowly)
On Tuesday, August 5, 2014, Stefan Tauner stefan.tauner@alumni.tuwien.ac.at wrote:
On Tue, 5 Aug 2014 00:54:03 -0400 TR Reardon <thomas_reardon@hotmail.com javascript:;> wrote:
Attempted write failed. Log attached. Haven't looked at further, but seems like partial reads work, but partial writes fail, due to early full-read before attempted partial-write.
I use the term "partial" to mean a single region in the layout file.
Yes, I agree. We read the whole flash first to be able to diagnose problems and recover from failures. Naturally this actually makes flashrom fail if it can't read anything. For now there is a read_all_first variable in doit() in flashrom.c that allows to turn this off manually.
You are also absolutely right about the write-only check for layout files in cli_classic.c. That check was introduced way after the layout patches were produced. I'll change that in my branch somewhere, thanks.
-- Kind regards/Mit freundlichen Grüßen, Stefan Tauner