On Thu, 12 Sep 2013 11:25:39 +0200 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com wrote:
ping?
Hi Ricardo,
I would have hoped for a more generic patch that adds some eeprom-specific infrastructure, but your approach seems to be legit when implementing this with the current infrastructure in flashrom. Sorry for not mentioning the opaque API before, that is of course the easiest way to get such things to work.
Would it be even possible to probe for IDs of the EEPROMs with the interface on the Intel NICs? What EEPROM model(s) do see on your boards?
I have not reviewed your patch in detail yet. There are probably a few coding style issues etc., but we can fix that ourselves if we have to. The bigger question is if we want to add something like it at all. I don't see good reason why we should not, but I need to discuss this with my colleague(s) (and that usually takes more time than one would expect). In any case your code is out there and can be used even if it does not get merged into vanilla flashrom eventually and your work is much appreciated, thank you.