Re: [flashrom] [PATCH] Refactor MCP SPI detection

[Michael Karcher]

Am Donnerstag, den 18.02.2010, 03:46 +0100 schrieb Carl-Daniel
Hailfinger:
> } else if (!mcp_spibaraddr && (buses_supported & CHIP_BUSTYPE_SPI)) {
> msg_pdbg("Strange. MCP SPI BAR is invalid.\n");
> buses_supported &= ~CHIP_BUSTYPE_SPI;

You might want to set ret to 1 here.

Nevertheless
Acked-by: Michael Karcher 
You can use the Ack for either version (with or with ret=1 at the point
quoted above).

Regards,
  Michael Karcher