Re: [flashrom] [PATCH 1/3] Let pkg-config work with cross-compilers.

[Stefan Tauner]

On Sun, 25 Jan 2015 02:10:08 +0100
Carl-Daniel Hailfinger  wrote:
> On 19.01.2015 21:39, Stefan Tauner wrote:
> > In cross-compiler setups pkg-config often needs some help to
> > determine the correct libraries. This can be done for example by
> > setting PKG_CONFIG_LIBDIR to point to the directory where the
> > cross-compile .pc files are located. If PKG_CONFIG_LIBDIR was not
> > set already outside of the Makefile we set it according to LIBS_BASE
> > and add the respective path to the linker's rpath. This makes it
> > possible to easily cross-compile by only setting CC and LIBS_BASE on
> > the command line.
> >
> > This patch also removes the explicit default for LIBS_BASE again
> > because it does not play well with this change and was a bad idea to
> > begin with.
> >
> > Signed-off-by: Stefan Tauner 
> > Acked-by: Stefan Tauner
>
> My only worry is that we might break native compilation on some
> architectures where the buildbot currently only checks crossbuilding.
>
> Apart from that, the reasoning and the code looks good (though I'm not
> really an expert in linker behaviour).
>
> Acked-by: Carl-Daniel Hailfinger

Thanks, r1876.