Re: [flashrom] [PATCH] LLVM/clang code review

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> Hi,
>
> On 15.09.2009 19:49, Stefan Reinauer wrote:
> > this patch fixes all 27 flashrom source code issues reported by
> > LLVM/clang's scan-build (r79326, new build on the way).
>
> It does fix the warnings, but it papers over some of the bugs found by
> scan-build. Given that the real bugfixes would have to revert parts of
> the patch, please hold off committing. I'll post a detailed review later.

Looking forward to that. I didn't intend to paper over anything. I
surely didn't intend a redesign of that code either though ;-)

Stefan